[Maintenance] Extract menus to separate files (changes split from #2472) #2511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
joel-jeremy
changed the title
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
joel-jeremy
changed the title
joel-jeremy
force-pushed
the
split-from-2472
branch
from
c52ccbc to
cee5fb5
Compare
MatissJanis
requested changes
Apr 2, 2024
packages/desktop-client/src/components/budget/rollover/CoverTooltip.tsx
Outdated
Show resolved
Hide resolved
| <View style={{ marginBottom: 5 }}>Cover from category:</View> | ||
|
|
||
| <InitialFocus> | ||
| {node => ( | ||
| <CategoryAutocomplete | ||
| categoryGroups={categoryGroups} | ||
| value={null} | ||
| value={categoryGroups.find(g => g.id === categoryId)} |
There was a problem hiding this comment.
🔨 warning: doesn't seem to work
Untitled.mov
There was a problem hiding this comment.
This is existing behavior, the value gets set but the autocomplete component clears the selection on blur by default.
packages/desktop-client/src/components/budget/rollover/TransferTooltip.tsx
Outdated
Show resolved
Hide resolved
trafico-bot
bot
added
⚠️ Changes requested
joel-jeremy
force-pushed
the
split-from-2472
branch
from
cee5fb5 to
7987f5c
Compare
trafico-bot
bot
added
🔍 Ready for Review
and removed
⚠️ Changes requested
MatissJanis
approved these changes
Apr 2, 2024
trafico-bot
bot
added
✨ Merged
|
@joel-jeremy @MatissJanis Edit: put in PR #2553 |
Merged
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split some changes from #2472 for easier review