-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add daily and weekly to custom reports interval list #2483
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@carkom can we reduce some of places we need to pass the firstDayOfWeekIdx around?
It looks like outside of loot core we could switch to importing it in reportRanges.ts, grouped-spreadsheet.ts, custom-spreadsheets.ts
and reduce the need to keep passing it around in the higher level components.
Can't call it inside the spreadsheet since they are called with "useMemo" it comes back with a hooks error. As for reportRanges I get an "invalid Hook Call" if I try to use it in the function directly. |
Ah, right. These aren't react components at this level, so we can't reference hooks in them. Apologies for the noise. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Has been working well in my testing. 👍
Just a couple tweaks to get weekly working. Most the backend groundwork has already been laid.Needs to "yearly" PR merged first.Done.Weekly became more complicated as I implented user prefs to match the begining of the week for the reports