-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mobile]: More functionalities #2472
Merged
Merged
Changes from 34 commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
db83253
Balance modals
joel-jeremy 238a9de
Release notes
joel-jeremy 849d864
Fix typecheck errors
joel-jeremy b350fde
Fix errors
joel-jeremy 5f481f7
Mobile scheduled transaction modal
joel-jeremy 8e49824
Cleanup
joel-jeremy 1992f77
Fix props
joel-jeremy 725dd14
Fix typecheck errors
joel-jeremy c141a19
Updates
joel-jeremy 033759c
Fix autocomplete typings
joel-jeremy e596360
Update autocomplete types
joel-jeremy e732d12
Fix typecheck errors
joel-jeremy 3168755
Fix typecheck errors
joel-jeremy 7f3543d
Remote optional type
joel-jeremy 2507561
Pass this to apply
joel-jeremy 919fbce
Use bind
joel-jeremy 5b416f3
Fix typecheck error
joel-jeremy 6c40ff3
Ignore typecheck error for now
joel-jeremy ca7f5b8
Add onClose in Autocomplete
joel-jeremy 9bd4778
open category modal on enter in transfer modal
joel-jeremy a680417
Budget summary modals
joel-jeremy f142e37
Accounts update
joel-jeremy 7617c94
Add paddingBottom
joel-jeremy 1fcb9ef
Fix typecheck error
joel-jeremy 43b20c3
Revert navigate
joel-jeremy 66f8c18
Disable esline
joel-jeremy 4ed9781
Close account and Reopen account
joel-jeremy f4b062d
Improve SingleInputModal
joel-jeremy abf68f3
Fix lint error
joel-jeremy e9d0a4a
Fix category autocomplete modal header
joel-jeremy e14ede9
Rebase updates
joel-jeremy db44102
Cleanup
joel-jeremy 66e4225
Clearer error message
joel-jeremy dfb61b0
Close report balance tooltip on selection
joel-jeremy 2ae6d8c
Updated based on review
joel-jeremy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file modified
BIN
+25 Bytes
(100%)
...s-snapshots/Mobile-creates-a-transaction-via-footer-button-5-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+16 Bytes
(100%)
...dividual-account-page-and-checks-that-filtering-is-working-1-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+17 Bytes
(100%)
...dividual-account-page-and-checks-that-filtering-is-working-3-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+15 Bytes
(100%)
...dividual-account-page-and-checks-that-filtering-is-working-5-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -166,6 +166,7 @@ type AccountItemProps = { | |
embedded?: boolean; | ||
}; | ||
|
||
// eslint-disable-next-line import/no-unused-modules | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ❓ question: what's the plan with this? Do you plan on using it in the near future? If not - we can remove the Same question for the other files. |
||
export function AccountItem({ | ||
item, | ||
className, | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to think about how to remove the need to wrap modal components with this in order for
useSheetValue
to work. By default, there is no namespace context for any of our modals.