Hide hidden categories in auto-complete #2429
Conversation
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
|
Nice. Wasn't it that we wanted to show hidden opposite of what you set this as? Show in filters and reports, hide when editing transactions. |
The last comment I saw was from you here. Saying hiding/showing descision is out of scope for this PR. I'd planned to follow that and hide it everywhere. As I said in OP, how I have it set now is temporary, for testing purposes. We can change that and decide now where to hide/show for each case. I'd be happy to make those changes now. From what I can see these are the locations it's used: |
|
I think long term I would vote for something like this |
If you close an on-budget account and transfer the balance to an off-budget account you are prompted to categorize the transfer via CategoryAutoComplete. I'd vote in include here. |
|
This all looks good to me. Are you wanting to get other input or are you ready to get this merged in? |
|
I like how this looks now. It was ever so briefly confusing when I went to select the hidden category: 
and the transaction category changed: 
and the name did not match. I had to mentally process that it was the right name, despite looking much shorter. But probably that is fine. But why are hidden categories not shown in the list in some places now? For example, setting a rule you can't make the category a hidden one? Similarly, I think being able to filter by them is very useful, especially in cases where you miscategorize something as a hidden category and need to find it again. |
Being able to set a hidden category in a rule doesn't make sense, if a category is hidden, it's not relevant any more. If it is indeed relevant, then it shouldn't be hidden.
I agree with this, or even just for wanting to see what you'd put against it(a hidden category) previously. The drop down list still appears when attempting to filter on the accounts screen for a category that: is hidden: Doesn't exist: Although this would go away if the above suggested behaviour to allow filtering hidden categories the same way as when adding a transaction is implemented. |
That logic probably makes sense for rollover budgeting. For report budgeting, I think what I describe makes sense. I have many things that show on my accounts that I don't consider part of my budget, so I hide them. I have a lot of rules set up to do that. |
This is not a rollover vs report discussion. You're both making assumptions on how everyone uses the software based on how you (personally) use the software. Some people hide categories they still actively use and some people hide categories that are no longer used. |
Only thing I'd change on your list is Filters. You can find transactions in hidden categories using the search bar. I forgot to add "Rules creation modal" which I'd vote for include. |
And with that in mind, it would probably make sense to keep hidden categories showing in most places because that would support more use cases. |
|
Hey all, thanks for getting this over the last hurdle! If I recall, the idea that people hide and keep using categories was raised early on and it was decided that we didn't want to support people using the software 'incorrectly'. I.e. Hidden categories should not be active |
trafico-bot
bot
added
✨ Merged
Picking up #1843 as it was basically complete. Seemed like everyone had come to concensus on how to implement and best UI, just needed some tweaks to get it passing CI. I've also added the same logic/process to the category groups that was applied to the items.
Props to @Shazib for doing all the legwork and coding.
I have
showhiddenitems = trueon "all accounts" transaction table so you can see what it looks like. It's disabled in the filters menu so you can compare. I plan to disable on the transactions table before merge.