Custom reports updates #2386

carkom · 2024-02-22T00:39:06Z

Some slight UI and visual changes to custom reports

netlify · 2024-02-22T00:39:25Z

✅ Deploy Preview for actualbudget ready!

Name	Link
🔨 Latest commit	`927c240`
🔍 Latest deploy log	https://app.netlify.com/sites/actualbudget/deploys/65e1b11e29f5ca0008caec53
😎 Deploy Preview	https://deploy-preview-2386.demo.actualbudget.org/
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions · 2024-02-22T00:40:25Z

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
10	4.47 MB → 4.47 MB (+1.13 kB)	+0.02%

Changeset

File	Δ	Size
`src/components/reports/reports/CustomReportListCards.tsx`	📈 +1.63 kB (+28.35%)	5.75 kB → 7.38 kB
`src/components/reports/ReportOptions.ts`	📈 +632 B (+16.06%)	3.84 kB → 4.46 kB
`src/components/reports/SaveReportName.tsx`	📈 +116 B (+5.34%)	2.12 kB → 2.24 kB
`src/components/reports/Header.jsx`	📈 +239 B (+4.51%)	5.18 kB → 5.41 kB
`src/components/reports/reports/CustomReport.jsx`	📈 +462 B (+3.23%)	13.97 kB → 14.42 kB
`src/components/reports/SaveReport.tsx`	📈 +86 B (+1.84%)	4.58 kB → 4.66 kB
`src/components/reports/ReportSidebar.jsx`	📈 +36 B (+0.22%)	16.23 kB → 16.26 kB
`src/components/reports/spreadsheets/net-worth-spreadsheet.ts`	📈 +4 B (+0.11%)	3.43 kB → 3.43 kB
`src/components/reports/spreadsheets/custom-spreadsheet.ts`	📉 -2 B (-0.05%)	3.62 kB → 3.62 kB
`src/components/reports/spreadsheets/grouped-spreadsheet.ts`	📉 -2 B (-0.06%)	3.11 kB → 3.11 kB
`src/components/reports/spreadsheets/recalculate.ts`	📉 -2 B (-0.13%)	1.5 kB → 1.5 kB
`src/components/reports/Overview.jsx`	📉 -166 B (-8.35%)	1.94 kB → 1.78 kB
`src/components/reports/reports/CustomReportCard.jsx`	🔥 -1.87 kB (-100%)	1.87 kB → 0 B

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset	File Size	% Changed
static/js/ReportRouter.js	1.21 MB → 1.21 MB (+1.13 kB)	+0.09%

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
static/js/indexeddb-main-thread-worker-e59fee74.js	13.5 kB	0%
static/js/resize-observer.js	18.37 kB	0%
static/js/ButtonLink.js	379 B	0%
static/js/BackgroundImage.js	122.29 kB	0%
static/js/BalanceTooltip.js	6.06 kB	0%
static/js/AppliedFilters.js	20.35 kB	0%
static/js/narrow.js	79.85 kB	0%
static/js/wide.js	267.47 kB	0%
static/js/index.js	2.74 MB	0%

github-actions · 2024-02-22T00:40:26Z

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
1	1.2 MB	0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
kcab.worker.js	1.2 MB	0%

Teprifer · 2024-02-23T09:37:31Z

Confirming categories sort per budget order when importing my budget.

Teprifer · 2024-02-24T08:59:22Z

Ok this is interesting, thought I'd dig a little deeper as I originally just checked my regular deposits filter in the default and came across some odd behaviour now:

Click create new custom report
Click Type and Net is disabled
Change Split By to Account
Change Split By back to Category
Click Type and Net is now available for selection
Click Net

By way of explanation since I cut off categories, the far right is "Income" and the one in the middle is a category with Deposit and Payments categorised to it, net positive

For comparison, this is the same graph, just changed Type back to Payment

youngcw · 2024-02-26T18:25:11Z

This is nice so far. I think it would be better long term to try to not use so much screen space for the create new report button. I would be a fan of a floating button, maybe at the bottom corner.

MatissJanis · 2024-02-28T08:03:38Z

This is nice so far. I think it would be better long term to try to not use so much screen space for the create new report button. I would be a fan of a floating button, maybe at the bottom corner.

+1

IMO a better location for the button would be at the top of the page (screenshot). Plus we should make it smaller and primary color.

And then we can get rid of the separator line between the graphs.

youngcw · 2024-02-28T18:52:15Z

sankey report now takes up a whole row in the dash

carkom · 2024-02-28T21:12:08Z

sankey report now takes up a whole row in the dash

Good catch. All set.

youngcw · 2024-02-28T21:36:25Z

After this is there anything else you think NEEDS to be included? or is this about ready to remove the feature flag?

carkom · 2024-02-28T21:47:28Z

After this is there anything else you think NEEDS to be included? or is this about ready to remove the feature flag?

There's two things I'd like to finish before removing feature flag.

incorporating "yearly" interval choice (I have a branch about 75% done)
create "disabledList" to make the functionality more consistent and the code easier to read (This branch is ready to submit)

My assumption is that the next release should have these PRs merged and a further PR to remove feature flag. Cheers!

MatissJanis · 2024-02-29T19:34:35Z

You mean the networth and cash flow cards?

Yes

MatissJanis · 2024-02-29T19:41:35Z

Found one more bug here: the spacing between the header and the other content is too small.

carkom · 2024-02-29T20:19:41Z

Both fixed. Cheers!

MatissJanis

Just a small nitpick on my end. Overall: LGTM!

(but please wait for another approval before merging as quite a few others were looking into this PR too)

packages/desktop-client/src/components/reports/reports/CustomReportListCards.tsx

twk3 · 2024-02-29T21:30:54Z

packages/desktop-client/src/components/reports/Overview.jsx

+            marginTop: 10,
+          }}
+        >
+          <ButtonLink to="/reports/custom" type="primary">


This is currently navigating to the last loaded custom report rather than to a new custom report if used after looking at a saved report. I think we want it to open a default report each time?

I'm not experiencing the same behavior. If I open a saved report then click "reports" in the main menu sidebar then click this button, I get a new default report. Is your experience different? How can I duplicate what you're seeing?

Looks like it starts happening if you load a custom report. Then go back to the cards and rename it from there. Then after the rename, click the button. (and it loads with the old name, prior to the rename)

I think I got it sorted, can you test again?

packages/desktop-client/src/components/reports/ReportOptions.ts

packages/desktop-client/src/components/reports/reports/CustomReport.jsx

carkom · 2024-03-01T09:49:42Z

I've also fixed a bug where the "rename" menu option was transfering the most recently used name and error messages to new card menu clicks.

Ready for review!

Teprifer · 2024-03-01T10:24:11Z

Appreciate adding the saved report name to the header, 2 verrry minor suggestions 'for another day' :)

Remove the 's' in reports to make it singular as it's a single report being viewed.
Add the (modified) tag when doing so with right save/load menu.

e.g.

carkom · 2024-03-01T10:44:09Z

Appreciate adding the saved report name to the header, 2 verrry minor suggestions 'for another day' :)
1. Remove the 's' in reports to make it singular as it's a single report being viewed.

2. Add the (modified) tag when doing so with right save/load menu.

I removed the "s" as that's an easy one. I've added the second suggestion to my feedback doc for a future PR.

twk3

The changes look good. Thanks @carkom

* Button changes and time filters * rename on dashboard * notes * fix time filters * Sort Categories * Page title * category sort order * move button * featureflag * Highlight report name * sankey fix * VRT * remove doubled element * update * fixes * fixes * create button fix and rename card fix * Title change

carkom added 2 commits February 21, 2024 23:19

Button changes and time filters

f61709e

rename on dashboard

8065909

trafico-bot bot added the 🔍 Ready for Review label Feb 22, 2024

carkom added 3 commits February 22, 2024 00:41

notes

4d4062e

fix time filters

eeea9d0

Sort Categories

28599fc

carkom mentioned this pull request Feb 23, 2024

[Feedback]: Custom Reports #1918

Closed

39 tasks

carkom added 2 commits February 23, 2024 11:15

Page title

76b77e1

category sort order

1162dd1

carkom added this to the v24.3.0 milestone Feb 27, 2024

carkom added 3 commits February 28, 2024 09:32

move button

f8cbfb0

featureflag

a34caa6

Highlight report name

cf51b01

sankey fix

73c0a80

Merge branch 'master' into reportUpdates

9b51136

VRT

01ae841

carkom and others added 2 commits February 28, 2024 21:58

Merge branch 'master' into reportUpdates

6cb39ea

remove doubled element

00e3b5b

carkom requested a review from MatissJanis February 29, 2024 18:15

fixes

18d704e

trafico-bot bot added the 🔍 Ready for Review label Feb 29, 2024

trafico-bot bot removed the ⚠️ Changes requested Pull Request needs changes before it can be reviewed again label Feb 29, 2024

MatissJanis previously approved these changes Feb 29, 2024

View reviewed changes

packages/desktop-client/src/components/reports/reports/CustomReportListCards.tsx Show resolved Hide resolved

trafico-bot bot added ✅ Approved and removed 🔍 Ready for Review labels Feb 29, 2024

twk3 requested changes Feb 29, 2024

View reviewed changes

trafico-bot bot added ⚠️ Changes requested Pull Request needs changes before it can be reviewed again and removed ✅ Approved labels Feb 29, 2024

fixes

feeb298

carkom dismissed MatissJanis’s stale review via feeb298 March 1, 2024 00:26

trafico-bot bot added 🔍 Ready for Review and removed ⚠️ Changes requested Pull Request needs changes before it can be reviewed again labels Mar 1, 2024

create button fix and rename card fix

f625f1e

Title change

927c240

carkom requested a review from twk3 March 1, 2024 13:34

twk3 approved these changes Mar 1, 2024

View reviewed changes

trafico-bot bot added ✅ Approved and removed 🔍 Ready for Review labels Mar 1, 2024

carkom merged commit 40296dc into actualbudget:master Mar 1, 2024
19 checks passed

trafico-bot bot added the ✨ Merged Pull Request has been merged successfully label Mar 1, 2024

carkom deleted the reportUpdates branch March 1, 2024 18:41

trafico-bot bot removed the ✅ Approved label Mar 1, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Custom reports updates #2386

Custom reports updates #2386

carkom commented Feb 22, 2024

netlify bot commented Feb 22, 2024 •

edited

Loading

github-actions bot commented Feb 22, 2024 •

edited

Loading

github-actions bot commented Feb 22, 2024 •

edited

Loading

Teprifer commented Feb 23, 2024

Teprifer commented Feb 24, 2024 •

edited

Loading

youngcw commented Feb 26, 2024

MatissJanis commented Feb 28, 2024

youngcw commented Feb 28, 2024

carkom commented Feb 28, 2024

youngcw commented Feb 28, 2024

carkom commented Feb 28, 2024 •

edited

Loading

MatissJanis commented Feb 29, 2024

MatissJanis commented Feb 29, 2024

carkom commented Feb 29, 2024

MatissJanis left a comment

twk3 Feb 29, 2024

carkom Mar 1, 2024

twk3 Mar 1, 2024

carkom Mar 1, 2024

carkom commented Mar 1, 2024

Teprifer commented Mar 1, 2024

carkom commented Mar 1, 2024

twk3 left a comment

Custom reports updates #2386

Custom reports updates #2386

Conversation

carkom commented Feb 22, 2024

netlify bot commented Feb 22, 2024 • edited Loading

✅ Deploy Preview for actualbudget ready!

github-actions bot commented Feb 22, 2024 • edited Loading

Bundle Stats — desktop-client

github-actions bot commented Feb 22, 2024 • edited Loading

Bundle Stats — loot-core

Teprifer commented Feb 23, 2024

Teprifer commented Feb 24, 2024 • edited Loading

youngcw commented Feb 26, 2024

MatissJanis commented Feb 28, 2024

youngcw commented Feb 28, 2024

carkom commented Feb 28, 2024

youngcw commented Feb 28, 2024

carkom commented Feb 28, 2024 • edited Loading

MatissJanis commented Feb 29, 2024

MatissJanis commented Feb 29, 2024

carkom commented Feb 29, 2024

MatissJanis left a comment

Choose a reason for hiding this comment

twk3 Feb 29, 2024

Choose a reason for hiding this comment

carkom Mar 1, 2024

Choose a reason for hiding this comment

twk3 Mar 1, 2024

Choose a reason for hiding this comment

carkom Mar 1, 2024

Choose a reason for hiding this comment

carkom commented Mar 1, 2024

Teprifer commented Mar 1, 2024

carkom commented Mar 1, 2024

twk3 left a comment

Choose a reason for hiding this comment

netlify bot commented Feb 22, 2024 •

edited

Loading

github-actions bot commented Feb 22, 2024 •

edited

Loading

github-actions bot commented Feb 22, 2024 •

edited

Loading

Teprifer commented Feb 24, 2024 •

edited

Loading

carkom commented Feb 28, 2024 •

edited

Loading