Consider child transactions when fuzzy matching imported transactions

[joel-jeremy]

Match split transaction entries when importing transactions

[netlify]

✅ Deploy Preview for actualbudget ready!

Name	Link
🔨 Latest commit	34a8950
🔍 Latest deploy log	https://app.netlify.com/sites/actualbudget/deploys/65bbbc9292270900082a1061
😎 Deploy Preview	https://deploy-preview-2309.demo.actualbudget.org
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[github-actions]

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
10	4.98 MB	0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
static/js/indexeddb-main-thread-worker-e59fee74.js	13.5 kB	0%
static/js/resize-observer.js	18.37 kB	0%
static/js/ButtonLink.js	379 B	0%
static/js/BackgroundImage.js	122.29 kB	0%
static/js/BalanceTooltip.js	6.06 kB	0%
static/js/FiltersMenu.js	28.92 kB	0%
static/js/narrow.js	80.18 kB	0%
static/js/wide.js	239.61 kB	0%
static/js/ReportRouter.js	1.84 MB	0%
static/js/index.js	2.64 MB	0%

[github-actions]

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
1	1.18 MB → 1.18 MB (-34 B)	-0.00%

Changeset

File	Δ	Size
packages/loot-core/src/server/accounts/sync.ts	📉 -46 B (-0.14%)	32.04 kB → 32 kB

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

Asset	File Size	% Changed
kcab.worker.js	1.18 MB → 1.18 MB (-34 B)	-0.00%

Unchanged

No assets were unchanged

[youngcw]

Have you tested this with SimpleFIN?

Should this get extended to file imports?

[joel-jeremy]

I was able to test in SimpleFIN. I don't have a GoCardless account so I haven't tested that. I have also applied the same on the file imports here: https://github.com/actualbudget/actual/pull/2309/files#diff-686fc94775444483c551d99e96c7bc92175543a53600f050fa2cdbe119b10523L640

[yoyotogblo]

What does it mean to fuzzy match a child trasnsaction from a split?

So if I have a split:
Parent Transaction $100
Child 1: Category - Food, Amount - $70
Child 2: Category - Toiletries, Amount - $30

The imported transaction would always be $100 so how would it match a child transaction? Shouldn't it be trying to match only the parent (which it currently does)?

[youngcw]

@yoyotogblo I believe the use case would be if you combined imported transactions into a single split, like a wire transfer and its fee for example. Each are single transactions in the bank, but could be nice to combine in Actual.

[yoyotogblo]

@yoyotogblo I believe the use case would be if you combined imported transactions into a single split, like a wire transfer and its fee for example. Each are single transactions in the bank, but could be nice to combine in Actual.

Is combining imported transactions possible in Actual? Personally, I prefer leaving the integrity of the transactions in place (so leaving those 2 transactions separate). But if combining is a thing, then I can see why this could be useful. Otherwise, not sure of a use-case for it.

[joel-jeremy]

Is combining imported transactions possible in Actual? Personally, I prefer leaving the integrity of the transactions in place (so leaving those 2 transactions separate). But if combining is a thing, then I can see why this could be useful. Otherwise, not sure of a use-case for it.

The most common use case for this is grouping the fee and the actual purchase together. Or breaking down credit card statements with the individual purchases/installments being child transactions.

[yoyotogblo]

The most common use case for this is grouping the fee and the actual purchase together. Or breaking down credit card statements with the individual purchases/installments being child transactions.

Thanks... How would you group the fee and actual purchase together? Or are you saying you manually enter the two transactions as one parent transaction and 2 child transactions, and then you want the imported transactions to match each child?

Also, I don't believe breaking down a transaction into many child transactions (split transactions) is applicable in this case because the imported transaction won't match any of the child transactions.

Sorry about all these questions. On my end, just a bit concerned about even more fuzzy matching when it has the potential to be the wrong match especially with Actual not requesting approval of matches (like YNAB does).