Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 (goCardless) patch incomplete migration #2308

Merged
merged 3 commits into from
Feb 1, 2024

Conversation

MatissJanis
Copy link
Member

Patching a migration that for whatever reason did not update the account_sync_source field. Thus goCardless broke for some random accounts.

Also patching the sync button in the UI:

  • the sync button should not be visible if the server is not connected (thus bank-sync will be unavailable)
  • the sync button should be disabled if the customer if offline (thus also the bank-sync will not be available until reconnection)

Copy link

netlify bot commented Feb 1, 2024

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit c56495e
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/65bba315ac54640008b2e543
😎 Deploy Preview https://deploy-preview-2308.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Feb 1, 2024

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 4.98 MB → 4.98 MB (+289 B) +0.01%
Changeset
File Δ Size
src/components/accounts/Header.jsx 📈 +289 B (+2.13%) 13.25 kB → 13.53 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
static/js/wide.js 239.61 kB → 239.9 kB (+289 B) +0.12%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/indexeddb-main-thread-worker-e59fee74.js 13.5 kB 0%
static/js/resize-observer.js 18.37 kB 0%
static/js/ButtonLink.js 379 B 0%
static/js/BackgroundImage.js 122.29 kB 0%
static/js/BalanceTooltip.js 6.06 kB 0%
static/js/FiltersMenu.js 28.92 kB 0%
static/js/narrow.js 80.18 kB 0%
static/js/ReportRouter.js 1.84 MB 0%
static/js/index.js 2.64 MB 0%

Copy link
Contributor

github-actions bot commented Feb 1, 2024

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.18 MB 0%
Changeset
File Δ Size
packages/loot-core/src/server/accounts/sync.ts 📉 -2 B (-0.01%) 32.04 kB → 32.04 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.18 MB 0%

@Kidglove57
Copy link

This may be linked to issue #2290

@MatissJanis MatissJanis added this to the v24.2.0 milestone Feb 1, 2024
@MatissJanis MatissJanis merged commit 7341914 into master Feb 1, 2024
18 of 19 checks passed
@MatissJanis MatissJanis deleted the matiss/patch-gocardless-sync branch February 1, 2024 16:40
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved labels Feb 1, 2024
FlorianLang06 pushed a commit to FlorianLang06/actual that referenced this pull request Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants