Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker start browser error #2304

Merged
merged 2 commits into from
Feb 3, 2024
Merged

Fix docker start browser error #2304

merged 2 commits into from
Feb 3, 2024

Conversation

twk3
Copy link
Contributor

@twk3 twk3 commented Jan 30, 2024

Don't launch browser when in docker

Fixes #2301

Don't launch browser when in docker
Copy link

netlify bot commented Jan 30, 2024

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 5ecc507
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/65b936743df3b300085428f2
😎 Deploy Preview https://deploy-preview-2304.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Jan 30, 2024

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 4.98 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/indexeddb-main-thread-worker-e59fee74.js 13.5 kB 0%
static/js/resize-observer.js 18.37 kB 0%
static/js/BackgroundImage.js 122.29 kB 0%
static/js/ButtonLink.js 379 B 0%
static/js/narrow.js 81.81 kB 0%
static/js/BalanceTooltip.js 6.06 kB 0%
static/js/FiltersMenu.js 28.92 kB 0%
static/js/wide.js 239.61 kB 0%
static/js/ReportRouter.js 1.84 MB 0%
static/js/index.js 2.64 MB 0%

Copy link
Contributor

github-actions bot commented Jan 30, 2024

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.18 MB 0%
Changeset
File Δ Size
packages/loot-core/src/server/accounts/sync.ts 📉 -2 B (-0.01%) 32.04 kB → 32.04 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.18 MB 0%

@jaarasys-henria
Copy link
Contributor

Great timing! Just dropped some extra details on #2301 and while I was writing the comment, I'm amazed to get notified about a related PR :D

@jaarasys-henria
Copy link
Contributor

FWIW, it seems to me that this PR fixes #2301 👍

Copy link
Contributor

@joel-jeremy joel-jeremy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@twk3 twk3 merged commit 3324dd5 into master Feb 3, 2024
19 checks passed
@twk3 twk3 deleted the twk3/fix-browser-start branch February 3, 2024 01:18
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved labels Feb 3, 2024
javripley pushed a commit to javripley/actual that referenced this pull request Feb 19, 2024
* Fix docker start browser error

Don't launch browser when in docker
FlorianLang06 pushed a commit to FlorianLang06/actual that referenced this pull request Mar 7, 2024
* Fix docker start browser error

Don't launch browser when in docker
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: yarn/node/vite issue starting up development container
3 participants