Change lookback and look forward time range when fuzzy matching #2300
Conversation
Change to 7 days prior and after for imported transactions when fuzzy matching
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
trafico-bot
bot
added
✨ Merged
…albudget#2300) Change to 7 days prior and after for imported transactions when fuzzy matching
Currently, when a new transaction is imported, if the transaction doesn't match an existing transaction with the same imported ID, Actual tries to fuzzy match the transaction with an existing transaction. To do this, Actual selects all existing transactions 4 days prior and 1 day after the imported transaction date. It then runs some logic to try to find a matching existing transaction from the ones selected.
The problem is 4 days prior and 1 day after is too restricting. The few issues are:
There's no reason why the match logic shouldn't be symmetrical (so 4 days prior and 4 days after)
Quite frequently, this logic fails to find the right transaction because the imported transaction might be 2 days after or 5 days prior. This is extremely noticeable with transfers between accounts. Here's an example:
Scenario A
I have a monthly transfer from Account A to Account B of $50. The transfer is initiated from Account A
On Jan 2nd, Account A records the outgoing transfer of $50. Actual sees this transaction and it's set as a transfer to Account B
On Jan 7th, Account B gets the incoming transfer of $50. Because this newly imported transaction "happened" 5 days after the imported transaction, it doesn't get matched and a new transfer to Account A is created
Scenario B
Let's imagine I delete the transaction on Jan 2nd
Because SimpleFin and GoCardless download all transactions 90 days prior, the transaction on Jan 2nd gets downloaded again
This time, it only tries to fuzzy match transaction up till Jan 3rd and doesn't see the Jan 7th transaction
Every new download of transactions lead to duplicate, unmatched transactions and have to continually be deleted.
Please review this PR and approve. Also, for some context, YNAB 5 actually uses 10 days prior and 10 days after for fuzzy matching (https://support.ynab.com/en_us/approving-and-matching-transactions-a-guide-ByYNZaQ1i).