-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update loot-core deps #2280
Update loot-core deps #2280
Conversation
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged No assets were unchanged |
1330825
to
cac2647
Compare
b3e39d2
to
6749ee7
Compare
cac2647
to
c5912a2
Compare
6749ee7
to
2959d03
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I confirmed the electron app was still working, and I didn't see any other errors when running the main app, or building the api.
I see we removed react-refresh (makes sense, vite loads it's own version I believe). And all the other version changes looked to be in the right direction.
@joel-jeremy curious how you checked which deps should be moved between devDependencies, is there some script for that?
Nope, I just categorized the dependencies manually and moved them where it makes sense |
* Upgrade desktop-client depenencies * yarn dedupe * Update useSelectors * Update loot-core deps * yarn dedupe * Move deps to devDependencies * yarn dedupe
No description provided.