Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update loot-core deps #2280

Merged
merged 7 commits into from
Feb 8, 2024
Merged

Update loot-core deps #2280

merged 7 commits into from
Feb 8, 2024

Conversation

joel-jeremy
Copy link
Contributor

No description provided.

Copy link

netlify bot commented Jan 24, 2024

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 2959d03
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/65c3a19c5b9ecf00080d31fe
😎 Deploy Preview https://deploy-preview-2280.demo.actualbudget.org/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@joel-jeremy joel-jeremy changed the base branch from master to update-desktop-client-package-versions January 24, 2024 19:31
Copy link
Contributor

github-actions bot commented Jan 24, 2024

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 4.96 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/indexeddb-main-thread-worker-e59fee74.js 13.5 kB 0%
static/js/resize-observer.js 18.37 kB 0%
static/js/BackgroundImage.js 122.29 kB 0%
static/js/ButtonLink.js 379 B 0%
static/js/BalanceTooltip.js 6.06 kB 0%
static/js/AppliedFilters.js 28.99 kB 0%
static/js/narrow.js 80.18 kB 0%
static/js/wide.js 241.78 kB 0%
static/js/ReportRouter.js 1.74 MB 0%
static/js/index.js 2.72 MB 0%

Copy link
Contributor

github-actions bot commented Jan 24, 2024

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.18 MB → 1.2 MB (+12.28 kB) +1.01%
Changeset
File Δ Size
node_modules/define-data-property/index.js 🆕 +2.77 kB 0 B → 2.77 kB
node_modules/set-function-length/index.js 🆕 +1.36 kB 0 B → 1.36 kB
node_modules/set-function-name/index.js 🆕 +623 B 0 B → 623 B
node_modules/hasown/index.js 🆕 +234 B 0 B → 234 B
node_modules/function-bind/implementation.js 📈 +580 B (+39.64%) 1.43 kB → 2 kB
node_modules/memfs/lib/setImmediate.js 📈 +98 B (+36.84%) 266 B → 364 B
node_modules/memfs/lib/node.js 📈 +3.81 kB (+29.54%) 12.9 kB → 16.72 kB
node_modules/assert/build/internal/errors.js 📈 +1.98 kB (+27.77%) 7.14 kB → 9.12 kB
node_modules/memfs/lib/internal/buffer.js 📈 +209 B (+22.07%) 947 B → 1.13 kB
node_modules/assert/build/assert.js 📈 +2.52 kB (+13.23%) 19.04 kB → 21.56 kB
node_modules/memfs/lib/setTimeoutUnref.js 📈 +51 B (+11.54%) 442 B → 493 B
node_modules/memfs/lib/volume.js 📈 +9.28 kB (+11.47%) 80.95 kB → 90.23 kB
node_modules/memfs/lib/encoding.js 📈 +81 B (+10.80%) 750 B → 831 B
node_modules/fs-monkey/lib/util/lists.js 📈 +127 B (+10.35%) 1.2 kB → 1.32 kB
node_modules/assert/build/internal/assert/assertion_error.js 📈 +1.29 kB (+6.03%) 21.39 kB → 22.68 kB
node_modules/memfs/lib/internal/errors.js 📈 +608 B (+5.05%) 11.75 kB → 12.35 kB
node_modules/memfs/lib/index.js 📈 +81 B (+3.89%) 2.03 kB → 2.11 kB
node_modules/memfs/lib/promises.js 📈 +220 B (+3.55%) 6.06 kB → 6.27 kB
node_modules/assert/build/internal/util/comparisons.js 📈 +701 B (+3.38%) 20.23 kB → 20.91 kB
node_modules/memfs/lib/constants.js 📈 +28 B (+2.75%) 1020 B → 1.02 kB
node_modules/which-typed-array/index.js 📈 +43 B (+1.82%) 2.31 kB → 2.35 kB
node_modules/deep-equal/index.js 📈 +223 B (+1.70%) 12.8 kB → 13.02 kB
node_modules/memfs/lib/Dirent.js 📈 +30 B (+1.63%) 1.8 kB → 1.83 kB
node_modules/memfs/lib/Stats.js 📈 +24 B (+0.84%) 2.8 kB → 2.83 kB
node_modules/get-intrinsic/index.js 📈 +3 B (+0.02%) 13.01 kB → 13.01 kB
node_modules/fs-monkey/lib/correctPath.js 📉 -3 B (-0.27%) 1.08 kB → 1.08 kB
node_modules/memfs/lib/process.js 📉 -82 B (-6.33%) 1.26 kB → 1.18 kB
node_modules/call-bind/index.js 📉 -94 B (-7.20%) 1.28 kB → 1.18 kB
node_modules/regexp.prototype.flags/implementation.js 📉 -152 B (-17.97%) 846 B → 694 B
node_modules/is-typed-array/index.js 📉 -1.58 kB (-91.36%) 1.73 kB → 153 B
node_modules/es6-object-assign/index.js 🔥 -1.14 kB (-100%) 1.14 kB → 0 B
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
kcab.worker.js 1.18 MB → 1.2 MB (+12.28 kB) +1.01%

Smaller

No assets were smaller

Unchanged

No assets were unchanged

@joel-jeremy joel-jeremy force-pushed the update-desktop-client-package-versions branch from 1330825 to cac2647 Compare January 30, 2024 19:04
@joel-jeremy joel-jeremy force-pushed the update-loot-core-deps branch 2 times, most recently from b3e39d2 to 6749ee7 Compare January 30, 2024 22:32
@joel-jeremy joel-jeremy force-pushed the update-desktop-client-package-versions branch from cac2647 to c5912a2 Compare February 6, 2024 21:38
Base automatically changed from update-desktop-client-package-versions to master February 7, 2024 01:43
@joel-jeremy joel-jeremy force-pushed the update-loot-core-deps branch from 6749ee7 to 2959d03 Compare February 7, 2024 15:28
Copy link
Contributor

@twk3 twk3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I confirmed the electron app was still working, and I didn't see any other errors when running the main app, or building the api.

I see we removed react-refresh (makes sense, vite loads it's own version I believe). And all the other version changes looked to be in the right direction.

@joel-jeremy curious how you checked which deps should be moved between devDependencies, is there some script for that?

@joel-jeremy
Copy link
Contributor Author

joel-jeremy commented Feb 7, 2024

curious how you checked which deps should be moved between devDependencies, is there some script for that?

Nope, I just categorized the dependencies manually and moved them where it makes sense

@joel-jeremy joel-jeremy merged commit 8a8113a into master Feb 8, 2024
19 checks passed
@joel-jeremy joel-jeremy deleted the update-loot-core-deps branch February 8, 2024 02:41
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved labels Feb 8, 2024
FlorianLang06 pushed a commit to FlorianLang06/actual that referenced this pull request Mar 7, 2024
* Upgrade desktop-client depenencies

* yarn dedupe

* Update useSelectors

* Update loot-core deps

* yarn dedupe

* Move deps to devDependencies

* yarn dedupe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants