-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update and organize reports #2274
Conversation
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller
Unchanged No assets were unchanged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few questions/comments. Overall I've checked that the change don't appear to break the existing functionality.
packages/desktop-client/src/components/reports/ReportSidebar.jsx
Outdated
Show resolved
Hide resolved
packages/desktop-client/src/components/reports/reports/CustomReport.jsx
Outdated
Show resolved
Hide resolved
packages/desktop-client/src/components/reports/reports/CustomReport.jsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@carkom one more fix needed here. Then I think this looks good.
Co-authored-by: DJ Mountney <[email protected]>
* Add schema work * notes * merge fixes * Add Reports Save Menu * merge fixes * updates * notes * updates * updates * save updates fix * typecheck fixes * revert changes * notes * error fixes * update * fix * merge fixes * review changes * reportChange and savedStatus * Update packages/desktop-client/src/components/reports/SaveReport.tsx Co-authored-by: DJ Mountney <[email protected]> * merge fixes --------- Co-authored-by: DJ Mountney <[email protected]>
This is some backend prep work for custom reports saved menu.