Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and organize reports #2274

Merged
merged 29 commits into from
Feb 3, 2024
Merged

Conversation

carkom
Copy link
Contributor

@carkom carkom commented Jan 22, 2024

This is some backend prep work for custom reports saved menu.

Copy link

netlify bot commented Jan 22, 2024

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit c118e11
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/65bd53810269280008f64f5a
😎 Deploy Preview https://deploy-preview-2274.demo.actualbudget.org/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Jan 22, 2024

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 4.98 MB → 4.99 MB (+2.32 kB) +0.05%
Changeset
File Δ Size
src/components/reports/reports/CustomReport.jsx 📈 +1.77 kB (+15.39%) 11.5 kB → 13.27 kB
src/components/reports/SaveReport.tsx 📈 +154 B (+9.16%) 1.64 kB → 1.79 kB
src/components/reports/ReportTopbar.jsx 📈 +142 B (+2.75%) 5.05 kB → 5.19 kB
src/components/reports/ReportSidebar.jsx 📈 +248 B (+1.65%) 14.71 kB → 14.95 kB
src/components/reports/ReportOptions.ts 📈 +47 B (+1.31%) 3.49 kB → 3.54 kB
home/runner/work/actual/actual/packages/loot-core/src/client/data-hooks/reports.ts 📉 -31 B (-4.24%) 731 B → 700 B
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
static/js/ReportRouter.js 1.84 MB → 1.84 MB (+2.32 kB) +0.12%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/resize-observer.js 18.37 kB 0%
static/js/indexeddb-main-thread-worker-e59fee74.js 13.5 kB 0%
static/js/BackgroundImage.js 122.29 kB 0%
static/js/ButtonLink.js 379 B 0%
static/js/narrow.js 80.18 kB 0%
static/js/BalanceTooltip.js 6.06 kB 0%
static/js/AppliedFilters.js 28.99 kB 0%
static/js/wide.js 240.44 kB 0%
static/js/index.js 2.64 MB 0%

Copy link
Contributor

github-actions bot commented Jan 22, 2024

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.18 MB → 1.18 MB (-50 B) -0.00%
Changeset
File Δ Size
packages/loot-core/src/server/reports/app.ts 📉 -184 B (-7.61%) 2.36 kB → 2.18 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

Asset File Size % Changed
kcab.worker.js 1.18 MB → 1.18 MB (-50 B) -0.00%

Unchanged

No assets were unchanged

Copy link
Contributor

@twk3 twk3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few questions/comments. Overall I've checked that the change don't appear to break the existing functionality.

@carkom carkom requested a review from twk3 January 31, 2024 13:41
@carkom carkom requested a review from twk3 February 1, 2024 15:20
Copy link
Contributor

@twk3 twk3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carkom one more fix needed here. Then I think this looks good.

@trafico-bot trafico-bot bot added ⚠️ Changes requested Pull Request needs changes before it can be reviewed again and removed 🔍 Ready for Review labels Feb 1, 2024
@trafico-bot trafico-bot bot added 🔍 Ready for Review and removed ⚠️ Changes requested Pull Request needs changes before it can be reviewed again labels Feb 1, 2024
@twk3 twk3 self-requested a review February 1, 2024 22:44
twk3
twk3 previously approved these changes Feb 1, 2024
@carkom carkom requested a review from twk3 February 2, 2024 20:44
@carkom carkom merged commit e3a8366 into actualbudget:master Feb 3, 2024
19 checks passed
@trafico-bot trafico-bot bot added the ✨ Merged Pull Request has been merged successfully label Feb 3, 2024
@carkom carkom deleted the updateOrganizeReports branch February 3, 2024 07:52
@trafico-bot trafico-bot bot removed the ✅ Approved label Feb 3, 2024
FlorianLang06 pushed a commit to FlorianLang06/actual that referenced this pull request Mar 7, 2024
* Add schema work

* notes

* merge fixes

* Add Reports Save Menu

* merge fixes

* updates

* notes

* updates

* updates

* save updates fix

* typecheck fixes

* revert changes

* notes

* error fixes

* update

* fix

* merge fixes

* review changes

* reportChange and savedStatus

* Update packages/desktop-client/src/components/reports/SaveReport.tsx

Co-authored-by: DJ Mountney <[email protected]>

* merge fixes

---------

Co-authored-by: DJ Mountney <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants