Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update desktop client package versions #2270

Merged
merged 7 commits into from
Feb 7, 2024

Conversation

joel-jeremy
Copy link
Contributor

@joel-jeremy joel-jeremy commented Jan 22, 2024

No functional changes. The code changes made here is to satisfy the compiler which looks for the generic type for useSelector calls.

Copy link

netlify bot commented Jan 22, 2024

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit c5912a2
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/65c2a6ccecbb8f000815f0bb
😎 Deploy Preview https://deploy-preview-2270.demo.actualbudget.org/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@joel-jeremy joel-jeremy force-pushed the update-desktop-client-package-versions branch 2 times, most recently from 123360c to aa6551f Compare January 23, 2024 19:32
Copy link
Contributor

github-actions bot commented Jan 23, 2024

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 4.99 MB → 4.96 MB (-32.68 kB) -0.64%
Changeset (largest 100 files by percent change)
File Δ Size
node_modules/@react-spring/core/dist/react-spring_core.modern.mjs 🆕 +58.12 kB 0 B → 58.12 kB
node_modules/@react-spring/shared/dist/react-spring_shared.modern.mjs 🆕 +27.69 kB 0 B → 27.69 kB
node_modules/react-virtualized-auto-sizer/dist/react-virtualized-auto-sizer.esm.js 🆕 +15.03 kB 0 B → 15.03 kB
node_modules/recharts/es6/component/TooltipBoundingBox.js 🆕 +10.09 kB 0 B → 10.09 kB
node_modules/recharts/es6/util/ActiveShapeUtils.js 🆕 +10.07 kB 0 B → 10.07 kB
node_modules/recharts/es6/util/ReduceCSSCalc.js 🆕 +8.54 kB 0 B → 8.54 kB
node_modules/@react-spring/animated/dist/react-spring_animated.modern.mjs 🆕 +8.15 kB 0 B → 8.15 kB
node_modules/@react-spring/web/dist/react-spring_web.modern.mjs 🆕 +7.71 kB 0 B → 7.71 kB
node_modules/recharts/es6/shape/Trapezoid.js 🆕 +7.08 kB 0 B → 7.08 kB
node_modules/recharts/es6/util/tooltip/translate.js 🆕 +4.99 kB 0 B → 4.99 kB
node_modules/recharts/es6/util/BarUtils.js 🆕 +4.26 kB 0 B → 4.26 kB
node_modules/recharts/es6/component/Cursor.js 🆕 +3.97 kB 0 B → 3.97 kB
node_modules/recharts/es6/util/getLegendProps.js 🆕 +3.5 kB 0 B → 3.5 kB
node_modules/recharts/es6/util/ScatterUtils.js 🆕 +1.73 kB 0 B → 1.73 kB
node_modules/recharts/es6/cartesian/getEquidistantTicks.js 🆕 +1.66 kB 0 B → 1.66 kB
node_modules/recharts/es6/util/TickUtils.js 🆕 +1.15 kB 0 B → 1.15 kB
node_modules/recharts/es6/util/cursor/getCursorPoints.js 🆕 +1.03 kB 0 B → 1.03 kB
node_modules/recharts/es6/util/isDomainSpecifiedByUser.js 🆕 +1.03 kB 0 B → 1.03 kB
node_modules/recharts/es6/util/cursor/getRadialCursorPoints.js 🆕 +651 B 0 B → 651 B
node_modules/recharts/es6/util/cursor/getCursorRectangle.js 🆕 +504 B 0 B → 504 B
node_modules/recharts/es6/util/payload/getUniqPayload.js 🆕 +463 B 0 B → 463 B
node_modules/clsx/dist/clsx.mjs 🆕 +368 B 0 B → 368 B
node_modules/tiny-invariant/dist/esm/tiny-invariant.js 🆕 +147 B 0 B → 147 B
node_modules/victory-core/es/victory-primitives/tspan.js 📈 +2.35 kB (+1483.33%) 162 B → 2.5 kB
node_modules/victory-core/es/victory-primitives/path.js 📈 +1.82 kB (+144.63%) 1.26 kB → 3.07 kB
node_modules/react-redux/es/index.js 📈 +59 B (+118.00%) 50 B → 109 B
node_modules/victory-core/es/victory-primitives/text.js 📈 +1.35 kB (+98.72%) 1.37 kB → 2.72 kB
node_modules/victory-core/es/victory-primitives/line.js 📈 +1.4 kB (+83.21%) 1.69 kB → 3.09 kB
node_modules/victory-core/es/victory-primitives/rect.js 📈 +1.4 kB (+82.16%) 1.71 kB → 3.11 kB
node_modules/victory-core/es/victory-primitives/circle.js 📈 +1.4 kB (+81.88%) 1.71 kB → 3.12 kB
node_modules/recharts/es6/component/ResponsiveContainer.js 📈 +2.43 kB (+36.69%) 6.63 kB → 9.07 kB
node_modules/react-router-dom/dist/index.js 📈 +2.37 kB (+32.87%) 7.21 kB → 9.58 kB
node_modules/react-smooth/es6/setRafTimeout.js 📈 +138 B (+32.09%) 430 B → 568 B
node_modules/recharts/es6/util/types.js 📈 +2.02 kB (+21.32%) 9.46 kB → 11.48 kB
node_modules/hotkeys-js/dist/hotkeys.esm.js 📈 +2.73 kB (+16.62%) 16.45 kB → 19.19 kB
node_modules/react-redux/es/hooks/useSelector.js 📈 +423 B (+15.18%) 2.72 kB → 3.13 kB
node_modules/@react-aria/utils/dist/import.mjs 📈 +4.77 kB (+12.21%) 39.11 kB → 43.88 kB
node_modules/d3-shape/src/noop.js 📈 +2 B (+11.11%) 18 B → 20 B
node_modules/@react-aria/i18n/dist/real-module.mjs 📈 +737 B (+10.67%) 6.75 kB → 7.46 kB
node_modules/@react-aria/focus/dist/import.mjs 📈 +3.44 kB (+9.47%) 36.32 kB → 39.76 kB
node_modules/react-router/dist/index.js 📈 +1.68 kB (+9.21%) 18.19 kB → 19.87 kB
node_modules/@react-aria/listbox/dist/import.mjs 📈 +984 B (+8.94%) 10.75 kB → 11.71 kB
node_modules/@react-aria/interactions/dist/import.mjs 📈 +4.84 kB (+8.20%) 59.01 kB → 63.85 kB
node_modules/recharts/es6/chart/AccessibilityManager.js 📈 +268 B (+4.82%) 5.43 kB → 5.69 kB
node_modules/@remix-run/router/dist/router.js 📈 +1.27 kB (+4.68%) 27.13 kB → 28.4 kB
node_modules/recharts/es6/cartesian/CartesianGrid.js 📈 +719 B (+4.48%) 15.67 kB → 16.37 kB
node_modules/recharts/es6/util/ChartUtils.js 📈 +1.57 kB (+4.21%) 37.19 kB → 38.75 kB
node_modules/@react-aria/selection/dist/import.mjs 📈 +1.6 kB (+3.96%) 40.4 kB → 41.99 kB
node_modules/victory-polar-axis/es/helper-methods.js 📈 +558 B (+3.89%) 14 kB → 14.54 kB
node_modules/victory-bar/es/bar-helper-methods.js 📈 +76 B (+3.58%) 2.07 kB → 2.15 kB
node_modules/victory-chart/es/victory-chart.js 📈 +177 B (+2.70%) 6.41 kB → 6.58 kB
node_modules/react-redux/es/components/Provider.js 📈 +23 B (+2.47%) 930 B → 953 B
node_modules/recharts/es6/container/Surface.js 📈 +47 B (+2.26%) 2.04 kB → 2.08 kB
node_modules/recharts/es6/cartesian/Brush.js 📈 +562 B (+2.24%) 24.52 kB → 25.07 kB
node_modules/@react-stately/selection/dist/import.mjs 📈 +393 B (+2.19%) 17.49 kB → 17.87 kB
node_modules/victory-core/es/victory-util/axis.js 📈 +305 B (+2.19%) 13.63 kB → 13.93 kB
node_modules/recharts/es6/cartesian/Line.js 📈 +505 B (+2.15%) 22.95 kB → 23.45 kB
node_modules/recharts/es6/component/DefaultLegendContent.js 📈 +217 B (+2.05%) 10.33 kB → 10.55 kB
node_modules/victory-core/es/victory-primitives/background.js 📈 +49 B (+1.93%) 2.48 kB → 2.53 kB
node_modules/victory-stack/es/victory-stack.js 📈 +122 B (+1.93%) 6.18 kB → 6.3 kB
node_modules/victory-core/es/victory-util/textsize.js 📈 +745 B (+1.91%) 38.08 kB → 38.81 kB
node_modules/recharts/es6/cartesian/Bar.js 📈 +386 B (+1.86%) 20.25 kB → 20.63 kB
node_modules/victory-core/es/victory-primitives/line-segment.js 📈 +48 B (+1.86%) 2.53 kB → 2.57 kB
node_modules/victory-core/es/victory-primitives/arc.js 📈 +56 B (+1.43%) 3.83 kB → 3.88 kB
node_modules/@react-aria/ssr/dist/import.mjs 📈 +52 B (+1.42%) 3.57 kB → 3.62 kB
node_modules/victory-axis/es/helper-methods.js 📈 +273 B (+1.22%) 21.87 kB → 22.13 kB
node_modules/glamor/lib/CSSPropertyOperations/dangerousStyleValue.js 📈 +10 B (+1.14%) 880 B → 890 B
home/runner/work/actual/actual/packages/loot-core/src/client/reducers/index.ts 📈 +2 B (+1.10%) 182 B → 184 B
src/components/BankSyncStatus.tsx 📈 +17 B (+1.09%) 1.52 kB → 1.54 kB
node_modules/recharts/es6/cartesian/ReferenceLine.js 📈 +73 B (+0.96%) 7.4 kB → 7.47 kB
node_modules/d3-array/src/quantile.js 📈 +8 B (+0.90%) 893 B → 901 B
home/runner/work/actual/actual/packages/loot-core/src/shared/async.ts 📈 +2 B (+0.88%) 227 B → 229 B
home/runner/work/actual/actual/packages/loot-core/src/client/reducers/user.ts 📈 +2 B (+0.87%) 229 B → 231 B
node_modules/victory-tooltip/es/flyout.js 📈 +54 B (+0.85%) 6.24 kB → 6.29 kB
node_modules/d3-shape/src/curve/linearClosed.js 📈 +4 B (+0.82%) 487 B → 491 B
node_modules/victory-core/es/victory-util/helpers.js 📈 +78 B (+0.71%) 10.78 kB → 10.86 kB
src/components/mobile/MobileNavTabs.tsx 📈 +30 B (+0.71%) 4.16 kB → 4.18 kB
node_modules/victory-core/es/victory-util/add-events.js 📈 +126 B (+0.69%) 17.92 kB → 18.05 kB
src/components/budget/BudgetSummaries.tsx 📈 +14 B (+0.61%) 2.24 kB → 2.25 kB
node_modules/memoize-one/dist/memoize-one.esm.js 📈 +8 B (+0.61%) 1.29 kB → 1.3 kB
home/runner/work/actual/actual/packages/loot-core/src/client/actions/sync.ts 📈 +8 B (+0.54%) 1.45 kB → 1.45 kB
node_modules/lodash/maxBy.js 📈 +5 B (+0.49%) 1012 B → 1017 B
node_modules/lodash/_defineProperty.js 📈 +1 B (+0.43%) 230 B → 231 B
node_modules/d3-array/src/max.js 📈 +2 B (+0.41%) 486 B → 488 B
node_modules/d3-array/src/min.js 📈 +2 B (+0.41%) 486 B → 488 B
node_modules/victory-core/es/victory-label/victory-label.js 📈 +68 B (+0.29%) 22.69 kB → 22.75 kB
node_modules/d3-shape/src/curve/basisClosed.js 📈 +4 B (+0.27%) 1.44 kB → 1.44 kB
home/runner/work/actual/actual/packages/loot-core/src/client/query-hooks.tsx 📈 +4 B (+0.23%) 1.73 kB → 1.73 kB
node_modules/recharts/es6/util/DataUtils.js 📈 +7 B (+0.19%) 3.53 kB → 3.54 kB
node_modules/lodash/upperFirst.js 📈 +1 B (+0.19%) 531 B → 532 B
node_modules/lodash/_baseAssignValue.js 📈 +1 B (+0.16%) 623 B → 624 B
node_modules/lodash/_baseSetToString.js 📈 +1 B (+0.16%) 631 B → 632 B
node_modules/lodash/isBoolean.js 📈 +1 B (+0.14%) 736 B → 737 B
node_modules/glamor/lib/plugins.js 📈 +4 B (+0.13%) 2.99 kB → 3 kB
node_modules/recharts/es6/util/ReactUtils.js 📈 +14 B (+0.13%) 10.58 kB → 10.59 kB
node_modules/lodash/flatMap.js 📈 +1 B (+0.12%) 861 B → 862 B
node_modules/lodash/get.js 📈 +1 B (+0.11%) 932 B → 933 B
node_modules/lodash/sumBy.js 📈 +1 B (+0.11%) 942 B → 943 B
node_modules/lodash/isNumber.js 📈 +1 B (+0.11%) 946 B → 947 B
node_modules/glamor/lib/CSSPropertyOperations/CSSProperty.js 📈 +4 B (+0.10%) 3.78 kB → 3.79 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
static/js/index.js 2.65 MB → 2.72 MB (+79.37 kB) +2.93%

Smaller

Asset File Size % Changed
static/js/ReportRouter.js 1.85 MB → 1.74 MB (-112.03 kB) -5.91%
static/js/wide.js 240.55 kB → 240.54 kB (-17 B) -0.01%

Unchanged

Asset File Size % Changed
static/js/indexeddb-main-thread-worker-e59fee74.js 13.5 kB 0%
static/js/resize-observer.js 18.37 kB 0%
static/js/ButtonLink.js 379 B 0%
static/js/BackgroundImage.js 122.29 kB 0%
static/js/BalanceTooltip.js 6.06 kB 0%
static/js/AppliedFilters.js 28.99 kB 0%
static/js/narrow.js 80.18 kB 0%

Copy link
Contributor

github-actions bot commented Jan 23, 2024

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.18 MB → 1.18 MB (-15 B) -0.00%
Changeset
File Δ Size
node_modules/uuid/dist/esm-browser/stringify.js 📉 -16 B (-1.08%) 1.45 kB → 1.43 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

Asset File Size % Changed
kcab.worker.js 1.18 MB → 1.18 MB (-15 B) -0.00%

Unchanged

No assets were unchanged

@joel-jeremy joel-jeremy force-pushed the update-desktop-client-package-versions branch from cb1412d to 1330825 Compare January 24, 2024 19:01
Copy link
Contributor

@twk3 twk3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question. Otherwise looks good.

packages/desktop-client/src/components/Modals.tsx Outdated Show resolved Hide resolved
@joel-jeremy joel-jeremy force-pushed the update-desktop-client-package-versions branch from 1330825 to cac2647 Compare January 30, 2024 19:04
twk3
twk3 previously approved these changes Jan 30, 2024
@joel-jeremy joel-jeremy merged commit 029e2f0 into master Feb 7, 2024
19 checks passed
@joel-jeremy joel-jeremy deleted the update-desktop-client-package-versions branch February 7, 2024 01:43
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved labels Feb 7, 2024
FlorianLang06 pushed a commit to FlorianLang06/actual that referenced this pull request Mar 7, 2024
* Upgrade desktop-client depenencies

* Release notes

* yarn dedupe

* yarn dedupe

* Fix typecheck error

* Update sass

* Update useSelectors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants