Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vite / swc / ts versions #2268

Merged
merged 7 commits into from
Jan 24, 2024
Merged

Update vite / swc / ts versions #2268

merged 7 commits into from
Jan 24, 2024

Conversation

joel-jeremy
Copy link
Contributor

No description provided.

Copy link

netlify bot commented Jan 22, 2024

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit d69ca6f
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/65b00cdea12f980008c18ca1
😎 Deploy Preview https://deploy-preview-2268.demo.actualbudget.org/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Jan 22, 2024

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 4.98 MB → 4.98 MB (+266 B) +0.01%
Changeset
File Δ Size
node_modules/tslib/tslib.es6.mjs 📈 +241 B (+20.62%) 1.14 kB → 1.38 kB
package.json 📈 +25 B (+0.91%) 2.69 kB → 2.71 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
static/js/index.js 2.64 MB → 2.64 MB (+266 B) +0.01%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/indexeddb-main-thread-worker-e59fee74.js 13.5 kB 0%
static/js/resize-observer.js 18.37 kB 0%
static/js/ButtonLink.js 379 B 0%
static/js/BackgroundImage.js 122.29 kB 0%
static/js/narrow.js 81.84 kB 0%
static/js/BalanceTooltip.js 6.06 kB 0%
static/js/FiltersMenu.js 28.92 kB 0%
static/js/wide.js 239.61 kB 0%
static/js/ReportRouter.js 1.84 MB 0%

Copy link
Contributor

github-actions bot commented Jan 22, 2024

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.24 MB → 1.18 MB (-54.63 kB) -4.32%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

Asset File Size % Changed
kcab.worker.js 1.24 MB → 1.18 MB (-54.63 kB) -4.32%

Unchanged

No assets were unchanged

@twk3
Copy link
Contributor

twk3 commented Jan 22, 2024

@joel-jeremy can you run a yarn dedupe on this. In particular I don't think there is value in having multiple vite versions resolved.

@joel-jeremy
Copy link
Contributor Author

@twk3 Ran the dedupe. Can you check if the dependencies are okay?

Copy link
Contributor

@twk3 twk3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The yarn.lock changes look to only be rolling things forward. And I didn't see any new warning when packaging the browser/electron/api.

@twk3 twk3 added this to the v24.2.0 milestone Jan 24, 2024
@joel-jeremy joel-jeremy merged commit 524bd4e into master Jan 24, 2024
19 checks passed
@joel-jeremy joel-jeremy deleted the upgrade-swc-and-ts branch January 24, 2024 18:49
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved labels Jan 24, 2024
FlorianLang06 pushed a commit to FlorianLang06/actual that referenced this pull request Mar 7, 2024
* Update vite / swc / ts versions

* Release notes

* Revert root tsconfig module changes

* yarn dedupe

* Dummy update to run pipeline

* Update webpack and playwright

* Update playwright docker images
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants