Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cleanup] useSingleActiveEditForm hook on mobile budget table #2263

Merged
merged 3 commits into from
Jan 30, 2024

Conversation

joel-jeremy
Copy link
Contributor

@joel-jeremy joel-jeremy commented Jan 21, 2024

No functional changes. This is just to re-use the same useSingleActiveEditForm hook that is currently being used in mobile transaction page. The hook prevents editing any other field when another one is currently being edited/active.

Copy link

netlify bot commented Jan 21, 2024

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit f798133
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/65b04826a1b8f40008b46b7f
😎 Deploy Preview https://deploy-preview-2263.demo.actualbudget.org/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@joel-jeremy joel-jeremy changed the title useSingleActiveEditForm on mobile budget table [Cleanup] useSingleActiveEditForm on mobile budget table Jan 21, 2024
@joel-jeremy joel-jeremy changed the title [Cleanup] useSingleActiveEditForm on mobile budget table [Cleanup] useSingleActiveEditForm on mobile budget table Jan 21, 2024
Copy link
Contributor

github-actions bot commented Jan 21, 2024

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 4.98 MB → 4.98 MB (-3.44 kB) -0.07%
Changeset
File Δ Size
src/components/transactions/SelectedTransactions.jsx 📉 -51 B (-1.04%) 4.79 kB → 4.74 kB
src/components/Modals.tsx 📉 -145 B (-1.66%) 8.54 kB → 8.4 kB
src/components/budget/MobileBudgetTable.jsx 📉 -668 B (-1.76%) 37.05 kB → 36.4 kB
src/components/schedules/ScheduleDetails.jsx 📉 -691 B (-2.46%) 27.46 kB → 26.78 kB
src/components/transactions/SimpleTransactionsTable.jsx 📉 -289 B (-4.23%) 6.68 kB → 6.39 kB
src/components/budget/MobileBudget.tsx 📉 -1002 B (-10.70%) 9.14 kB → 8.16 kB
src/components/schedules/ScheduleLink.tsx 📉 -673 B (-23.30%) 2.82 kB → 2.16 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

Asset File Size % Changed
static/js/index.js 2.64 MB → 2.64 MB (-1.76 kB) -0.06%
static/js/narrow.js 81.84 kB → 80.21 kB (-1.63 kB) -1.99%
static/js/wide.js 239.66 kB → 239.61 kB (-51 B) -0.02%

Unchanged

Asset File Size % Changed
static/js/indexeddb-main-thread-worker-e59fee74.js 13.5 kB 0%
static/js/resize-observer.js 18.37 kB 0%
static/js/BackgroundImage.js 122.29 kB 0%
static/js/ButtonLink.js 379 B 0%
static/js/BalanceTooltip.js 6.06 kB 0%
static/js/FiltersMenu.js 28.92 kB 0%
static/js/ReportRouter.js 1.84 MB 0%

Copy link
Contributor

github-actions bot commented Jan 21, 2024

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.24 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.24 MB 0%

@joel-jeremy joel-jeremy changed the title [Cleanup] useSingleActiveEditForm on mobile budget table [Cleanup] useSingleActiveEditForm hook on mobile budget table Jan 21, 2024
@joel-jeremy joel-jeremy force-pushed the single-active-form-mobile-budgets-page branch from 2ea71c9 to f798133 Compare January 23, 2024 23:13
@joel-jeremy joel-jeremy added this to the v24.2.0 milestone Jan 24, 2024
Copy link
Contributor

@twk3 twk3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup 👍 . Confirmed the behaviour remained the same.

@joel-jeremy joel-jeremy merged commit 54d7e54 into master Jan 30, 2024
19 checks passed
@joel-jeremy joel-jeremy deleted the single-active-form-mobile-budgets-page branch January 30, 2024 22:37
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed 🔍 Ready for Review labels Jan 30, 2024
FlorianLang06 pushed a commit to FlorianLang06/actual that referenced this pull request Mar 7, 2024
…budget#2263)

* useSingleActiveEditForm on mobile budget table

* Release notes

* Remove unused variables
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants