Custom Reports: add save reports menu #2257
Conversation
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
|
|
||
| import { v4 as uuidv4 } from 'uuid'; | ||
|
|
||
| //import { send, sendCatch } from 'loot-core/src/platform/client/fetch'; |
There was a problem hiding this comment.
Saved for next PR where db table is created and save menu is functional
| if (menuItem === 'save-report') { | ||
| //create new flow | ||
| /* | ||
| res = await sendCatch('report/create', { |
There was a problem hiding this comment.
Next PR will use this to save the report props to the db table
| }; | ||
| //send update and rename to DB | ||
| /* | ||
| res = await sendCatch('report/update', { |
There was a problem hiding this comment.
Next PR will use this to update the report props to the db table
carkom
changed the title
|
This is ready for review. Please keep in mind that while the menu works it's only saving to the page state not to any database as the table will be created in the next PR. This is just to get the menu functioning as intended, will add db table and connections next. |
|
Wahoo! While I've started trying to learn the code side of things(inspired in no small part to what I'm seeing yourself and others do with Actual) I'm still about useful there as a dead fish on a hot day. So nothing from me there. I do like the context aware menu, options are all self explanatory and discoverable. Revert changes = awesome! Some notes from poking around:
On these last three points, there are some graphs I'd want them visible on, and others I wouldn't. Overall I'd expect the 'look' I create for a report would include these options as they form a part of it. Suggestions:
From your comment re: saving I'm going to assume the drop down menu for report selection is later for obvious reasons. Not specific to this PR, but I did note that you can toggle labels on the table chart, which doesn't make sense. I'll add this to the main feedback thread to keep it separate. |
|
Thanks for the UI review and subsequent feedback! Legend/Summary/Label choices are all global variables so they stay as is. If you navigate away from the report (to accounts screen for example) then come back, they will be as you left them. This is as intended and not likely to change. Thanks for the suggestions they are both good ideas. |
trafico-bot
bot
added
✨ Merged
* Add schema work * notes * merge fixes * Add Reports Save Menu * merge fixes * updates * notes * updates * updates * save updates fix * typecheck fixes * merge fixes * saveReport strict Typescript * fix sidebar * lint fix * fixing functionality plus clean up * clean up
Expanding the menu for saving reports and adding hooks and logic.
The actual "save to db" code is commented out as the table doesn't exist yet.