🔥 removing unused variables (batch 2)

.eslintrc.js

@@ -57,7 +57,6 @@ module.exports = {
     '@typescript-eslint/no-unused-vars': [
       'warn',
       {
-        args: 'none',
         varsIgnorePattern: '^_',
         ignoreRestSiblings: true,
       },

packages/desktop-client/src/browser-preload.browser.js

@@ -51,7 +51,7 @@ global.Actual = {
     window.location.reload();
   },
 
-  openFileDialog: async ({ filters = [], properties }) => {
+  openFileDialog: async ({ filters = [] }) => {
     return new Promise(resolve => {
       let createdElement = false;
       // Attempt to reuse an already-created file input.
@@ -91,7 +91,7 @@ global.Actual = {
               .uploadFile(filename, ev.target.result)
               .then(() => resolve([filepath]));
           };
-          reader.onerror = function (ev) {
+          reader.onerror = function () {
             alert('Error reading file');
           };
         }
@@ -107,7 +107,7 @@ global.Actual = {
     });
   },
 
-  saveFile: (contents, defaultFilename, dialogTitle) => {
+  saveFile: (contents, defaultFilename) => {
     const temp = document.createElement('a');
     temp.style = 'display: none';
     temp.download = defaultFilename;
@@ -121,9 +121,9 @@ global.Actual = {
   openURLInBrowser: url => {
     window.open(url, '_blank');
   },
-  onEventFromMain: (type, handler) => {},
+  onEventFromMain: () => {},
   applyAppUpdate: () => {},
-  updateAppMenu: isBudgetOpen => {},
+  updateAppMenu: () => {},
 
   ipcConnect: () => {},
   getServerSocket: async () => {

packages/desktop-client/src/components/FatalError.tsx

@@ -131,7 +131,7 @@ function SharedArrayBufferOverride() {
       >
         <Checkbox
           checked={understand}
-          onChange={_ => setUnderstand(!understand)}
+          onChange={() => setUnderstand(!understand)}
         />{' '}
         I understand the risks, run Actual in the unsupported fallback mode
       </label>

packages/desktop-client/src/components/FixedSizeList.tsx

@@ -2,7 +2,6 @@
 import {
   createRef,
   PureComponent,
-  type ReactElement,
   type ReactNode,
   type Ref,
   type MutableRefObject,
@@ -11,7 +10,6 @@ import {
 
 import memoizeOne from 'memoize-one';
 
-import { useResizeObserver } from '../hooks/useResizeObserver';
 import { type CSSProperties } from '../style';
 
 import { View } from './common/View';
@@ -20,16 +18,6 @@ const IS_SCROLLING_DEBOUNCE_INTERVAL = 150;
 
 const defaultItemKey: FixedSizeListProps['itemKey'] = (index: number) => index;
 
-type ResizeObserverProps = {
-  onResize: Parameters<typeof useResizeObserver>[0];
-  children: (ref: Ref<HTMLDivElement>) => ReactElement;
-};
-
-function ResizeObserver({ onResize, children }: ResizeObserverProps) {
-  const ref = useResizeObserver(onResize);
-  return children(ref);
-}
-
 type FixedSizeListProps = {
   className?: string;
   direction?: 'rtl' | 'ltr';
@@ -262,33 +250,29 @@ export class FixedSizeList extends PureComponent<
     const estimatedTotalSize = this.getEstimatedTotalSize();
 
     return (
-      <ResizeObserver onResize={this.onHeaderResize}>
-        {headerRef => (
-          <div
-            className={className}
-            onScroll={this._onScrollVertical}
-            ref={this._outerRefSetter}
-            style={{
-              height,
-              width,
-              overflow: 'hidden auto',
-            }}
-          >
-            <View innerRef={headerRef}>{header}</View>
-            <div
-              ref={innerRef}
-              style={{
-                position: 'relative',
-                height: estimatedTotalSize,
-                width: '100%',
-                pointerEvents: isScrolling ? 'none' : undefined,
-              }}
-            >
-              {items}
-            </div>
-          </div>
-        )}
-      </ResizeObserver>
+      <div
+        className={className}
+        onScroll={this._onScrollVertical}
+        ref={this._outerRefSetter}
+        style={{
+          height,
+          width,
+          overflow: 'hidden auto',
+        }}
+      >
+        <View>{header}</View>
+        <div
+          ref={innerRef}
+          style={{
+            position: 'relative',
+            height: estimatedTotalSize,
+            width: '100%',
+            pointerEvents: isScrolling ? 'none' : undefined,
+          }}
+        >
+          {items}
+        </div>
+      </div>
     );
   }
 
@@ -305,10 +289,6 @@ export class FixedSizeList extends PureComponent<
     }
   };
 
-  onHeaderResize = (rect: { height: number }) => {
-    // this.setState({ headerHeight: rect.height });
-  };
-
   anchor() {
     const itemKey = this.props.itemKey || defaultItemKey;
 
@@ -499,6 +479,7 @@ export class FixedSizeList extends PureComponent<
     return style;
   };
 
+  // eslint-disable-next-line @typescript-eslint/no-unused-vars
   _getItemStyleCache = memoizeOne((_, __, ___) => ({}));
 
   _getRangeToRender() {

packages/desktop-client/src/components/ManageRules.tsx

@@ -230,7 +230,7 @@ function ManageRulesContent({
     dispatch(
       pushModal('edit-rule', {
         rule,
-        onSave: async newRule => {
+        onSave: async () => {
           await loadRules();
           setLoading(false);
         },

packages/desktop-client/src/components/accounts/Account.jsx

@@ -227,7 +227,7 @@ class AccountInternal extends PureComponent {
       }
     };
 
-    const onUndo = async ({ tables, messages, undoTag }) => {
+    const onUndo = async ({ tables, messages }) => {
       await maybeRefetch(tables);
 
       // If all the messages are dealing with transactions, find the
@@ -516,7 +516,7 @@ class AccountInternal extends PureComponent {
           });
         }
       },
-      mappedData => {
+      () => {
         return data;
       },
     );

packages/desktop-client/src/components/accounts/MobileAccount.jsx

@@ -43,7 +43,7 @@ const getSchedulesTransform = memoizeOne((id, hasSearch) => {
   };
 });
 
-function PreviewTransactions({ accountId, children }) {
+function PreviewTransactions({ children }) {
   const scheduleData = useCachedSchedules();
 
   if (scheduleData == null) {

packages/desktop-client/src/components/budget/MobileBudget.tsx

@@ -408,19 +408,15 @@ function BudgetInner(props: BudgetInnerProps) {
         await sync();
       }}
     >
-      {({ refreshing, onRefresh }) => (
+      {({ onRefresh }) => (
         <BudgetTable
           // This key forces the whole table rerender when the number
           // format changes
           key={numberFormat + hideFraction}
           categoryGroups={categoryGroups}
-          categories={categories}
           type={budgetType}
           month={currentMonth}
           monthBounds={bounds}
-          //   refreshControl={
-          //     <RefreshControl refreshing={refreshing} onRefresh={onRefresh} />
-          //   }
           editMode={editMode}
           onEditMode={flag => setEditMode(flag)}
           onShowBudgetSummary={onShowBudgetSummary}
@@ -438,9 +434,6 @@ function BudgetInner(props: BudgetInnerProps) {
           onBudgetAction={applyBudgetAction}
           onRefresh={onRefresh}
           onSwitchBudgetType={onSwitchBudgetType}
-          onSaveNotes={onSaveNotes}
-          onEditGroupNotes={onEditGroupNotes}
-          onEditCategoryNotes={onEditCategoryNotes}
           savePrefs={savePrefs}
           pushModal={pushModal}
           onEditGroup={onEditGroup}

packages/desktop-client/src/components/budget/MobileBudgetTable.jsx

@@ -145,7 +145,7 @@ function BudgetCell({
     });
   }
 
-  function onAmountClick(e) {
+  function onAmountClick() {
     onEdit?.(categoryId);
   }
 
@@ -243,7 +243,6 @@ const ExpenseCategory = memo(function ExpenseCategory({
   blank,
   style,
   month,
-  editMode,
   onEdit,
   isEditingBudget,
   onEditBudget,
@@ -569,7 +568,6 @@ const IncomeGroupTotals = memo(function IncomeGroupTotals({
   budgeted,
   balance,
   style,
-  editMode,
   onEdit,
 }) {
   const listItemRef = useRef();
@@ -657,7 +655,6 @@ const IncomeCategory = memo(function IncomeCategory({
   balance,
   month,
   style,
-  editMode,
   onEdit,
   onBudgetAction,
   isEditingBudget,
@@ -1122,7 +1119,6 @@ function BudgetGroups({
 export function BudgetTable({
   type,
   categoryGroups,
-  categories,
   month,
   monthBounds,
   editMode,
@@ -1143,9 +1139,6 @@ export function BudgetTable({
   onBudgetAction,
   onRefresh,
   onSwitchBudgetType,
-  onSaveNotes,
-  onEditGroupNotes,
-  onEditCategoryNotes,
   savePrefs,
   pushModal,
   onEditGroup,
@@ -1154,7 +1147,6 @@ export function BudgetTable({
   onEditCategoryBudget,
   openBalanceActionMenuId,
   onOpenBalanceActionMenu,
-  ...props
 }) {
   const { width } = useResponsive();
   const show3Cols = width >= 360;

packages/desktop-client/src/components/budget/SidebarCategory.tsx

@@ -154,7 +154,7 @@ export function SidebarCategory({
     >
       <InputCell
         value={category.name}
-        formatter={value => displayed}
+        formatter={() => displayed}
         width="flex"
         exposed={editing || temporary}
         onUpdate={value => {

packages/desktop-client/src/components/budget/SidebarGroup.tsx

@@ -27,7 +27,6 @@ type SidebarGroupProps = {
   collapsed: boolean;
   dragPreview?: boolean;
   innerRef?: ConnectDragSource;
-  borderColor?: string;
   style?: CSSProperties;
   onEdit?: (id: string) => void;
   onSave?: (group: object) => Promise<void>;
@@ -44,7 +43,6 @@ export function SidebarGroup({
   dragPreview,
   innerRef,
   style,
-  borderColor = theme.tableBorder,
   onEdit,
   onSave,
   onDelete,
@@ -63,7 +61,7 @@ export function SidebarGroup({
         userSelect: 'none',
         WebkitUserSelect: 'none',
       }}
-      onClick={e => {
+      onClick={() => {
         onToggleCollapse(group.id);
       }}
     >
@@ -181,7 +179,7 @@ export function SidebarGroup({
     >
       <InputCell
         value={group.name}
-        formatter={value => displayed}
+        formatter={() => displayed}
         width="flex"
         exposed={editing}
         onUpdate={value => {

packages/desktop-client/src/components/budget/index.tsx

@@ -533,7 +533,7 @@ const RolloverBudgetSummary = memo<{ month: string }>(props => {
   );
 });
 
-export function Budget(props) {
+export function Budget() {
   const startMonth = useSelector(
     state => state.prefs.local['budget.startMonth'],
   );

packages/desktop-client/src/components/budget/report/BalanceTooltip.tsx

@@ -38,7 +38,7 @@ export function BalanceTooltip({
       {...tooltipProps}
     >
       <Menu
-        onMenuSelect={type => {
+        onMenuSelect={() => {
           onBudgetAction(monthIndex, 'carryover', {
             category: categoryId,
             flag: !carryover,

packages/desktop-client/src/components/budget/rollover/CoverTooltip.tsx

@@ -48,7 +48,7 @@ export function CoverTooltip({
             categoryGroups={categoryGroups}
             value={null}
             openOnFocus={true}
-            onUpdate={id => {}}
+            onUpdate={() => {}}
             onSelect={id => setCategory(id)}
             inputProps={{
               inputRef: node,

packages/desktop-client/src/components/budget/rollover/TransferTooltip.tsx

@@ -98,7 +98,7 @@ export function TransferTooltip({
         categoryGroups={categoryGroups}
         value={null}
         openOnFocus={true}
-        onUpdate={id => {}}
+        onUpdate={() => {}}
         onSelect={id => setCategory(id)}
         inputProps={{ onEnter: submit, placeholder: '(none)' }}
       />

packages/desktop-client/src/components/budget/rollover/budgetsummary/BudgetSummary.tsx

@@ -35,7 +35,7 @@ export function BudgetSummary({
   } = useRollover();
 
   const [menuOpen, setMenuOpen] = useState(false);
-  function onMenuOpen(e) {
+  function onMenuOpen() {
     setMenuOpen(true);
   }
 

packages/desktop-client/src/components/common/Menu.tsx

@@ -163,7 +163,7 @@ export function Menu<T extends MenuItem>({
             }}
             onMouseEnter={() => setHoveredIndex(idx)}
             onMouseLeave={() => setHoveredIndex(null)}
-            onClick={e =>
+            onClick={() =>
               !item.disabled && onMenuSelect && onMenuSelect(item.name)
             }
           >

packages/desktop-client/src/components/modals/CategoryGroupMenu.tsx

@@ -137,7 +137,7 @@ export function CategoryGroupMenu({
               notes={notes?.length > 0 ? notes : 'No notes'}
               editable={false}
               focused={false}
-              getStyle={editable => ({
+              getStyle={() => ({
                 ...styles.mediumText,
                 borderRadius: 6,
                 ...((!notes || notes.length === 0) && {