Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔥 removing unused variables (batch 1) #2255

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Conversation

MatissJanis
Copy link
Member

Just removing some unused variables + unused code.

Related: #1907

Copy link

netlify bot commented Jan 19, 2024

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 09bf690
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/65aaf7041dcdea0008b6a9be
😎 Deploy Preview https://deploy-preview-2255.demo.actualbudget.org/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 5.08 MB → 5.08 MB (-329 B) -0.01%
Changeset
File Δ Size
src/components/select/DateSelect.tsx 📉 -1 B (-0.01%) 8.41 kB → 8.41 kB
src/components/reports/CategorySelector.tsx 📉 -9 B (-0.11%) 8.06 kB → 8.05 kB
home/runner/work/actual/actual/packages/loot-core/src/client/actions/queries.ts 📉 -10 B (-0.13%) 7.53 kB → 7.52 kB
home/runner/work/actual/actual/packages/loot-core/src/client/actions/account.ts 📉 -8 B (-0.19%) 4.2 kB → 4.19 kB
src/components/table.tsx 📉 -50 B (-0.20%) 23.96 kB → 23.91 kB
src/components/modals/ImportTransactions.jsx 📉 -85 B (-0.22%) 37.21 kB → 37.13 kB
src/components/util/AmountInput.tsx 📉 -10 B (-0.28%) 3.48 kB → 3.47 kB
src/components/transactions/SimpleTransactionsTable.jsx 📉 -19 B (-0.29%) 6.41 kB → 6.39 kB
src/components/schedules/SchedulesTable.tsx 📉 -46 B (-0.45%) 10.06 kB → 10.02 kB
src/components/sidebar/Accounts.tsx 📉 -62 B (-1.62%) 3.73 kB → 3.67 kB
src/components/rules/RulesHeader.tsx 📉 -19 B (-2.65%) 716 B → 697 B
home/runner/work/actual/actual/packages/loot-core/src/platform/exceptions/index.browser.ts 📉 -10 B (-7.69%) 130 B → 120 B
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

Asset File Size % Changed
static/js/index.js 2.63 MB → 2.63 MB (-320 B) -0.01%
static/js/ReportRouter.js 1.95 MB → 1.95 MB (-9 B) -0.00%

Unchanged

Asset File Size % Changed
static/js/indexeddb-main-thread-worker-e59fee74.js 13.5 kB 0%
static/js/resize-observer.js 18.37 kB 0%
static/js/BackgroundImage.js 122.29 kB 0%
static/js/ButtonLink.js 379 B 0%
static/js/narrow.js 82.17 kB 0%
static/js/BalanceTooltip.js 6.07 kB 0%
static/js/FiltersMenu.js 28.92 kB 0%
static/js/wide.js 239.01 kB 0%

Copy link
Contributor

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.23 MB → 1.23 MB (-383 B) -0.03%
Changeset
File Δ Size
packages/loot-core/src/server/main.ts 📉 -3 B (-0.00%) 63.69 kB → 63.69 kB
packages/loot-core/src/server/sync/index.ts 📉 -2 B (-0.01%) 23.23 kB → 23.23 kB
packages/loot-core/src/server/aql/compiler.ts 📉 -4 B (-0.01%) 34.76 kB → 34.76 kB
packages/loot-core/src/server/cloud-storage.ts 📉 -3 B (-0.02%) 12.18 kB → 12.18 kB
packages/loot-core/src/server/accounts/rules.ts 📉 -12 B (-0.05%) 23.11 kB → 23.1 kB
packages/loot-core/src/server/schedules/app.ts 📉 -9 B (-0.05%) 16.96 kB → 16.95 kB
packages/loot-core/src/server/spreadsheet/spreadsheet.ts 📉 -7 B (-0.06%) 12.09 kB → 12.09 kB
packages/loot-core/src/server/importers/ynab4.ts 📉 -10 B (-0.08%) 12.31 kB → 12.3 kB
packages/loot-core/src/platform/server/fs/index.web.ts 📉 -8 B (-0.08%) 9.68 kB → 9.67 kB
packages/loot-core/src/platform/server/asyncStorage/index.web.ts 📉 -4 B (-0.12%) 3.18 kB → 3.18 kB
packages/loot-core/src/platform/server/indexeddb/index.web.ts 📉 -8 B (-0.15%) 5.17 kB → 5.16 kB
packages/loot-core/migrations/1632571489012_remove_cache.js 📉 -6 B (-0.16%) 3.61 kB → 3.61 kB
packages/loot-core/src/server/importers/actual.ts 📉 -3 B (-0.20%) 1.44 kB → 1.44 kB
packages/loot-core/src/server/db/index.ts 📉 -155 B (-0.87%) 17.49 kB → 17.34 kB
packages/loot-core/src/server/api.ts 📉 -165 B (-0.94%) 17.12 kB → 16.96 kB
packages/api/methods.js 📉 -158 B (-1.24%) 12.41 kB → 12.25 kB
packages/loot-core/src/server/schedules/find-schedules.ts 📉 -171 B (-1.45%) 11.52 kB → 11.35 kB
packages/loot-core/src/platform/exceptions/index.web.ts 📉 -10 B (-6.85%) 146 B → 136 B
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

Asset File Size % Changed
kcab.worker.js 1.23 MB → 1.23 MB (-383 B) -0.03%

Unchanged

No assets were unchanged

@MatissJanis MatissJanis merged commit ae3be13 into master Jan 19, 2024
19 checks passed
@MatissJanis MatissJanis deleted the matiss/unused-vars-1 branch January 19, 2024 23:02
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved labels Jan 19, 2024
FlorianLang06 pushed a commit to FlorianLang06/actual that referenced this pull request Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants