Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Reports: fix broken table #2249

Merged
merged 3 commits into from
Jan 19, 2024
Merged

Conversation

carkom
Copy link
Contributor

@carkom carkom commented Jan 19, 2024

I had a comparison typescript matching issue that causes the table graph in custom reports to crash.

Copy link

netlify bot commented Jan 19, 2024

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 5d485d0
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/65aa91e0b94a5a0008d517dc
😎 Deploy Preview https://deploy-preview-2249.demo.actualbudget.org/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Jan 19, 2024

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 5.08 MB → 5.08 MB (+25 B) +0.00%
Changeset
File Δ Size
src/components/reports/graphs/tableGraph/ReportTableTotals.tsx 📈 +40 B (+1.11%) 3.52 kB → 3.56 kB
src/components/reports/graphs/tableGraph/ReportTableRow.tsx 📈 +9 B (+0.32%) 2.77 kB → 2.78 kB
src/components/reports/graphs/tableGraph/ReportTable.tsx 📉 -10 B (-0.62%) 1.57 kB → 1.56 kB
src/components/reports/graphs/tableGraph/ReportTableList.tsx 📉 -14 B (-0.78%) 1.75 kB → 1.74 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
static/js/ReportRouter.js 1.95 MB → 1.95 MB (+25 B) +0.00%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/resize-observer.js 18.37 kB 0%
static/js/indexeddb-main-thread-worker-e59fee74.js 13.5 kB 0%
static/js/BackgroundImage.js 122.29 kB 0%
static/js/ButtonLink.js 379 B 0%
static/js/BalanceTooltip.js 6.07 kB 0%
static/js/FiltersMenu.js 28.92 kB 0%
static/js/narrow.js 82.17 kB 0%
static/js/wide.js 239.01 kB 0%
static/js/index.js 2.63 MB 0%

Copy link
Contributor

github-actions bot commented Jan 19, 2024

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.23 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.23 MB 0%

Copy link
Contributor

@twk3 twk3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed this fixes the data table custom report.

I still see a separate react error in Time mode due to duplicate keys on Cells. But this is fixing the fatal errors.

@carkom carkom merged commit 06cf654 into actualbudget:master Jan 19, 2024
19 checks passed
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved labels Jan 19, 2024
@carkom carkom deleted the brokenTable branch January 20, 2024 11:32
FlorianLang06 pushed a commit to FlorianLang06/actual that referenced this pull request Mar 7, 2024
* fix broken table

* notes

* error fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants