Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Reports compact additions #2245

Merged
merged 8 commits into from
Jan 19, 2024
Merged

Conversation

carkom
Copy link
Contributor

@carkom carkom commented Jan 17, 2024

Adding compact identifier to all of the graphs and cleaning them up. Plus other staging bits for saving custom reports.

Copy link

netlify bot commented Jan 17, 2024

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 119b170
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/65a9b39cc620ac00087baa1d
😎 Deploy Preview https://deploy-preview-2245.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Jan 17, 2024

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 5.08 MB → 5.08 MB (+1.21 kB) +0.02%
Changeset
File Δ Size
src/hooks/useFilters.ts 📈 +81 B (+5.83%) 1.36 kB → 1.44 kB
src/components/reports/graphs/LineGraph.tsx 📈 +198 B (+5.63%) 3.43 kB → 3.63 kB
src/components/reports/graphs/BarLineGraph.tsx 📈 +198 B (+5.36%) 3.61 kB → 3.8 kB
src/components/common/MenuButton.tsx 📈 +18 B (+5.36%) 336 B → 354 B
src/components/reports/graphs/StackedBarGraph.tsx 📈 +242 B (+5.12%) 4.62 kB → 4.85 kB
src/components/reports/graphs/BarGraph.tsx 📈 +246 B (+3.63%) 6.61 kB → 6.85 kB
src/components/reports/ChooseGraph.tsx 📈 +113 B (+3.46%) 3.19 kB → 3.3 kB
src/components/reports/graphs/tableGraph/ReportTable.tsx 📈 +26 B (+1.64%) 1.55 kB → 1.57 kB
src/style/styles.ts 📈 +36 B (+0.97%) 3.61 kB → 3.65 kB
src/components/reports/graphs/tableGraph/ReportTableList.tsx 📈 +9 B (+0.51%) 1.74 kB → 1.75 kB
src/components/reports/graphs/tableGraph/ReportTableHeader.tsx 📈 +9 B (+0.39%) 2.27 kB → 2.28 kB
src/components/reports/reports/CustomReport.jsx 📈 +42 B (+0.37%) 10.96 kB → 11 kB
src/components/reports/graphs/DonutGraph.tsx 📈 +12 B (+0.25%) 4.62 kB → 4.63 kB
src/components/reports/graphs/tableGraph/ReportTableTotals.tsx 📈 +9 B (+0.25%) 3.52 kB → 3.52 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
static/js/ReportRouter.js 1.95 MB → 1.95 MB (+1.16 kB) +0.06%
static/js/index.js 2.63 MB → 2.63 MB (+36 B) +0.00%
static/js/wide.js 238.99 kB → 239.01 kB (+18 B) +0.01%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/resize-observer.js 18.37 kB 0%
static/js/indexeddb-main-thread-worker-e59fee74.js 13.5 kB 0%
static/js/BackgroundImage.js 122.29 kB 0%
static/js/ButtonLink.js 379 B 0%
static/js/BalanceTooltip.js 6.07 kB 0%
static/js/FiltersMenu.js 28.92 kB 0%
static/js/narrow.js 82.17 kB 0%

Copy link
Contributor

github-actions bot commented Jan 17, 2024

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.23 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.23 MB 0%

@carkom carkom changed the title Custom Report compact additions Custom Reports compact additions Jan 17, 2024
MatissJanis
MatissJanis previously approved these changes Jan 18, 2024
upcoming-release-notes/2245.md Outdated Show resolved Hide resolved
Co-authored-by: Matiss Janis Aboltins <[email protected]>
MatissJanis
MatissJanis previously approved these changes Jan 18, 2024
@carkom carkom requested a review from MatissJanis January 18, 2024 23:29
@carkom carkom merged commit 62a0a0f into actualbudget:master Jan 19, 2024
19 checks passed
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved labels Jan 19, 2024
@carkom carkom deleted the graphCards branch January 19, 2024 09:00
FlorianLang06 pushed a commit to FlorianLang06/actual that referenced this pull request Mar 7, 2024
* compact additions

* notes

* vrt fix

* revert AnchorLink

* Update upcoming-release-notes/2245.md

Co-authored-by: Matiss Janis Aboltins <[email protected]>

* merge fixes

---------

Co-authored-by: Matiss Janis Aboltins <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants