Change the vite chunk filename hash usage #2224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change to more closely match the . syntax we use with webpack - This shoudl fix some issues with our size compare as well
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded
Removed
Bigger No assets were bigger Smaller No assets were smaller Unchanged No assets were unchanged |
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
twk3
changed the title
twk3
force-pushed
the
twk3/fix-vite-chunk-hash
branch
from
afd1515 to
1bb93a5
Compare
twk3
force-pushed
the
twk3/fix-vite-chunk-hash
branch
from
1bb93a5 to
78bb827
Compare
Closed
twk3
changed the title
joel-jeremy
approved these changes
Jan 13, 2024
trafico-bot
bot
added
✨ Merged
FlorianLang06
pushed a commit
to FlorianLang06/actual
that referenced
this pull request
Mar 7, 2024
* Change the vite chunk filename hash usage - Change to more closely match the . syntax we use with webpack - This should fix some issues with our size compare as well * Account for chunks being base64
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
.chunksyntax we use with webpackDetails
The improvement for size compare is that our github action is stripping out the hashes before passing the size compare, but was based on the period.
We have the additional difficulty here of rollup using base64 hashes, which can include
_-which complicates our ability to just strip out what we want.This should improve the output, but there likely is a few more tweaks to be made, as our current vite stats seem to be missing the css and font sizes, which were previously present in this action.
Test
Because this action uses
pull_request_targetonly the action from master is run. In order to test the changes here I opened a sibling PR using justpull_reqest.You can see the test comment here: #2225 (comment)
and if you expand the
View detailed bundle breakdownyou can see the new naming at work in theAddedsection vs the current master naming at work in theRemovedsection.