Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vite host regression fix #2217

Merged
merged 4 commits into from
Jan 13, 2024
Merged

vite host regression fix #2217

merged 4 commits into from
Jan 13, 2024

Conversation

carkom
Copy link
Contributor

@carkom carkom commented Jan 12, 2024

Before we switched to vite, npm/yarn had a "allowHost" option which hosted the server to allow access from outside the local. This adds the "host" option back.

Copy link

netlify bot commented Jan 12, 2024

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit d277578
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/65a1e83955f6f7000877a5ee
😎 Deploy Preview https://deploy-preview-2217.demo.actualbudget.org/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Jan 12, 2024

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 5.08 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/indexeddb-main-thread-worker-e59fee74-bhyX5Ad6.js 13.5 kB 0%
static/js/resize-observer-6FaCDon1.js 18.37 kB 0%
static/js/BackgroundImage-Q5jAG3sp.js 122.29 kB 0%
static/js/ButtonLink-a1T-UOz9.js 379 B 0%
static/js/FiltersMenu-YozESp5f.js 28.92 kB 0%
static/js/BalanceTooltip-brisSaqR.js 6.07 kB 0%
static/js/narrow-bw0TL0em.js 82.17 kB 0%
static/js/wide-my42oBrS.js 236.3 kB 0%
static/js/ReportRouter-2BFn3u16.js 1.95 MB 0%
static/js/index-8P7Lx5aG.js 2.63 MB 0%

Copy link
Contributor

github-actions bot commented Jan 12, 2024

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.23 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.23 MB 0%

@carkom carkom requested a review from twk3 January 12, 2024 14:18
joel-jeremy
joel-jeremy previously approved these changes Jan 12, 2024
Copy link
Contributor

@twk3 twk3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carkom let's add this to the vite config instead so it's similar to how we had it for craco.

In https://github.com/actualbudget/actual/blob/master/packages/desktop-client/vite.config.mts#L132 you can add host: true to the server block.

https://vitejs.dev/config/server-options.html#server-host

@trafico-bot trafico-bot bot added ⚠️ Changes requested Pull Request needs changes before it can be reviewed again and removed 🔍 Ready for Review labels Jan 12, 2024
@trafico-bot trafico-bot bot added 🔍 Ready for Review and removed ⚠️ Changes requested Pull Request needs changes before it can be reviewed again labels Jan 12, 2024
@carkom
Copy link
Contributor Author

carkom commented Jan 12, 2024

@carkom let's add this to the vite config instead so it's similar to how we had it for craco.

In https://github.com/actualbudget/actual/blob/master/packages/desktop-client/vite.config.mts#L132 you can add host: true to the server block.

https://vitejs.dev/config/server-options.html#server-host

Done. Thanks!

@carkom carkom requested a review from twk3 January 12, 2024 22:00
@twk3
Copy link
Contributor

twk3 commented Jan 13, 2024

Thanks @carkom !

@twk3 twk3 merged commit dccad90 into actualbudget:master Jan 13, 2024
19 checks passed
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved labels Jan 13, 2024
@carkom carkom deleted the viteHost branch January 13, 2024 06:08
FlorianLang06 pushed a commit to FlorianLang06/actual that referenced this pull request Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants