🐛 (autocomplete) fix multi-autocomplete causing crashes #2207
Conversation
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| @@ -31,16 +31,12 @@ function findItem<T extends Item>( | |||
| strict: boolean, | |||
| suggestions: T[], | |||
| value: T | T['id'], | |||
| ): T | null { | |||
| ): T | T['id'] | null { | |||
There was a problem hiding this comment.
Ideally I would have liked to define a type overload for this function so that if strict: true is used - the input value would be T and strict: false would be T['id']. But that's not possible due to a TS limitation
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller
Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
trafico-bot
bot
added
✨ Merged
Closes #2187