Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:feat: (electron) show 'create demo budget' button on all envs #2197

Closed
wants to merge 3 commits into from

Conversation

MatissJanis
Copy link
Member

@MatissJanis MatissJanis commented Jan 8, 2024

Why?

I'm working on publishing the electron (desktop) app to App Store (OSX). Later potentially to other app-stores too.

When a user first opens up an app that he has installed - he sees the configuration screen. But there is no way to actually test the app properly. You could create an empty budget.. but testing that way will not be great UX.

So I am proposing here to always show the "create demo budget" button on the first screen of the app.

Copy link

netlify bot commented Jan 8, 2024

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 7341df2
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/659c45215a400100083258a6
😎 Deploy Preview https://deploy-preview-2197.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Jan 8, 2024

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
15 3.08 MB → 3.08 MB (-13 B) -0.00%
Changeset
File Δ Size
src/components/manager/ConfigServer.tsx 📉 -60 B (-0.80%) 7.33 kB → 7.27 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

Asset File Size % Changed
static/js/main.js 1.43 MB → 1.43 MB (-13 B) -0.00%

Unchanged

Asset File Size % Changed
static/js/665.chunk.js 824.28 kB 0%
static/media/Inter-italic.var.woff2 239.29 kB 0%
static/media/Inter-roman.var.woff2 221.86 kB 0%
static/js/231.chunk.js 117.38 kB 0%
static/js/wide-components.chunk.js 112.37 kB 0%
static/js/reports.chunk.js 77.81 kB 0%
static/js/narrow-components.chunk.js 42.42 kB 0%
static/js/553.chunk.js 13.14 kB 0%
static/js/473.chunk.js 13 kB 0%
static/js/resize-observer-polyfill.chunk.js 8.88 kB 0%
static/css/main.css 7.41 kB 0%
asset-manifest.json 1.92 kB 0%
index.html 1.66 kB 0%
static/media/browser-server.js 911 B 0%

Copy link
Contributor

github-actions bot commented Jan 8, 2024

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
2 2.23 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.24 MB 0%
xfo.xfo.kcab.worker.js 1014.45 kB 0%

@MatissJanis MatissJanis closed this Jan 8, 2024
@MatissJanis MatissJanis deleted the matiss/demo-button branch January 8, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant