Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change the pie chart background color in the report status #2196

Merged
merged 2 commits into from
Jan 8, 2024

Conversation

youngcw
Copy link
Member

@youngcw youngcw commented Jan 8, 2024

I was thinking that the color of the report budget pie chart background looked a bit off, especially in dark mode. This would change the color to match the table background instead of the page background.

Existing:
image
image

New:
image
image

Copy link

netlify bot commented Jan 8, 2024

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 9792a70
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/659c288459fa0f0008ab7348
😎 Deploy Preview https://deploy-preview-2196.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Jan 8, 2024

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
15 3.08 MB → 3.08 MB (+2 B) +0.00%
Changeset
File Δ Size
src/components/budget/report/budgetsummary/IncomeProgress.tsx 📈 +1 B (+0.11%) 890 B → 891 B
src/components/budget/report/budgetsummary/ExpenseProgress.tsx 📈 +1 B (+0.09%) 1.14 kB → 1.14 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
static/js/main.js 1.43 MB → 1.43 MB (+2 B) +0.00%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/665.chunk.js 824.28 kB 0%
static/media/Inter-italic.var.woff2 239.29 kB 0%
static/media/Inter-roman.var.woff2 221.86 kB 0%
static/js/231.chunk.js 117.38 kB 0%
static/js/wide-components.chunk.js 112.27 kB 0%
static/js/reports.chunk.js 77.81 kB 0%
static/js/narrow-components.chunk.js 42.42 kB 0%
static/js/553.chunk.js 13.14 kB 0%
static/js/473.chunk.js 13 kB 0%
static/js/resize-observer-polyfill.chunk.js 8.88 kB 0%
static/css/main.css 7.41 kB 0%
asset-manifest.json 1.92 kB 0%
index.html 1.66 kB 0%
static/media/browser-server.js 911 B 0%

Copy link
Contributor

github-actions bot commented Jan 8, 2024

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
2 2.23 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.24 MB 0%
xfo.xfo.kcab.worker.js 1014.45 kB 0%

@youngcw youngcw merged commit 300ed82 into master Jan 8, 2024
19 checks passed
@youngcw youngcw deleted the youngcw/report-status-backgroud-color branch January 8, 2024 18:20
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved labels Jan 8, 2024
FlorianLang06 pushed a commit to FlorianLang06/actual that referenced this pull request Mar 7, 2024
…get#2196)

* change the pie chart background color in the report status

* note
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants