Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 (electron) release electron app to app store (osx) #2182

Merged
merged 10 commits into from
Jan 9, 2024

Conversation

MatissJanis
Copy link
Member

@MatissJanis MatissJanis commented Jan 6, 2024

Code-sign and notarize the electron apps. This should allow us to publish the app to the app store (mac).

Also added a "view demo" button to the very first screen of the desktop app. This will allow for desktop users to quickly jump into the app if they just want to play around with it.

@trafico-bot trafico-bot bot added the 🚧 WIP label Jan 6, 2024
Copy link

netlify bot commented Jan 6, 2024

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 303d9f8
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/659c49e15a40010008d935ad
😎 Deploy Preview https://deploy-preview-2182.demo.actualbudget.org/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Jan 6, 2024

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
15 3.08 MB → 3.08 MB (+193 B) +0.01%
Changeset
File Δ Size
src/components/manager/WelcomeScreen.tsx 📈 +705 B (+17.97%) 3.83 kB → 4.52 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
static/js/main.js 1.43 MB → 1.43 MB (+193 B) +0.01%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/665.chunk.js 824.28 kB 0%
static/media/Inter-italic.var.woff2 239.29 kB 0%
static/media/Inter-roman.var.woff2 221.86 kB 0%
static/js/231.chunk.js 117.38 kB 0%
static/js/wide-components.chunk.js 112.37 kB 0%
static/js/reports.chunk.js 77.81 kB 0%
static/js/narrow-components.chunk.js 42.42 kB 0%
static/js/553.chunk.js 13.14 kB 0%
static/js/473.chunk.js 13 kB 0%
static/js/resize-observer-polyfill.chunk.js 8.88 kB 0%
static/css/main.css 7.41 kB 0%
asset-manifest.json 1.92 kB 0%
index.html 1.66 kB 0%
static/media/browser-server.js 911 B 0%

Copy link
Contributor

github-actions bot commented Jan 6, 2024

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
2 2.23 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.24 MB 0%
xfo.xfo.kcab.worker.js 1014.45 kB 0%

Copy link
Contributor

github-actions bot commented Jan 6, 2024

The VRT tests have passed! Thank you!

@actualbudget actualbudget deleted a comment from github-actions bot Jan 7, 2024
@MatissJanis MatissJanis changed the title [WIP] 🔧 (electron) release electron app to app store (osx) 🔧 (electron) release electron app to app store (osx) Jan 8, 2024
@MatissJanis MatissJanis marked this pull request as ready for review January 8, 2024 20:29
@MatissJanis
Copy link
Member Author

Ready for review.

I will update the docs page about publishing releases after v24.2.0 (hopefully the first version where we release the desktop app).

@MatissJanis MatissJanis merged commit 7ace8c5 into master Jan 9, 2024
19 checks passed
@MatissJanis MatissJanis deleted the matiss/electron-app branch January 9, 2024 18:54
@trafico-bot trafico-bot bot added the ✨ Merged Pull Request has been merged successfully label Jan 9, 2024
@trafico-bot trafico-bot bot removed the ✅ Approved label Jan 9, 2024
FlorianLang06 pushed a commit to FlorianLang06/actual that referenced this pull request Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants