Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix when pressing Enter adds an extra split transaction when no split remains #2144

Merged
merged 3 commits into from
Jan 6, 2024
Merged

Fix when pressing Enter adds an extra split transaction when no split remains #2144

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dd0a143
Fix pressing enter adds split transaction when no split remains
jasonmichalski Dec 30, 2023
cee33b2
Added release notes
jasonmichalski Dec 30, 2023
38a22b1
Refactor to use find indstead of findIndex
jasonmichalski Jan 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/desktop-client/src/components/transactions/TransactionsTable.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1967,7 +1967,10 @@ export const TransactionTable = forwardRef((props, ref) => {
afterSave(() => {
const transactions = latestState.current.transactions;
const idx = transactions.findIndex(t => t.id === id);
const parent = transactionMap.get(transactions[idx]?.parent_id);
const parentIdx = transactions.findIndex(
t => t.id === transactions[idx]?.parent_id,
);
const parent = transactions[parentIdx];
Copy link
Contributor

@kymckay kymckay Jan 1, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: you could use .find directly if the index isn't used anywhere else.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call - fixed!


if (
isLastChild(transactions, idx) &&
Expand Down
6 changes: 6 additions & 0 deletions upcoming-release-notes/2144.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
category: Bugfix
authors: [jasonmichalski]
---

Fix when pressing Enter adds an extra split transaction when no split remains
Loading