(ESLint) Enforce filename extensions for jsx #2101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- JSX content must use .jsx or .tsx here - Files that don't contain JSX can't use those two extensions
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset (largest 100 files by percent change)
View detailed bundle breakdownAdded
Removed
Bigger
Smaller No assets were smaller Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
twk3
changed the title
twk3
commented
Dec 18, 2023
| @@ -282,9 +287,6 @@ module.exports = { | |||
| }, | |||
| ], | |||
| settings: { | |||
| 'import/parsers': { | |||
| '@typescript-eslint/parser': ['.ts', '.tsx'], | |||
There was a problem hiding this comment.
This is included already with the import/typescript extends: https://github.com/import-js/eslint-plugin-import/blob/main/config/typescript.js
twk3
commented
Dec 18, 2023
| @@ -39,6 +39,7 @@ module.exports = { | |||
| 'react-app', | |||
| 'plugin:react/recommended', | |||
| 'plugin:@typescript-eslint/recommended', | |||
| 'plugin:import/typescript', | |||
There was a problem hiding this comment.
this adds tsx and jsx to the resolved imports so their filenames don't need to be specified in imports
trafico-bot
bot
added
✨ Merged
FlorianLang06
pushed a commit
to FlorianLang06/actual
that referenced
this pull request
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for considering moving to vite, which requires JSX content to be in one of these file extensions.
Currently this MR is also removing the x from files that don't contain JSX, (and enforcing that via eslint as well), but that is optional and not required for moving to vite. (Just seemed logical to me).
The eslint file contains the only content changes, everything else is just extension renames.
Split out of #2084