Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 1878 #2093

Merged
merged 2 commits into from
Dec 15, 2023
Merged

Fix issue 1878 #2093

merged 2 commits into from
Dec 15, 2023

Conversation

HansiWursti
Copy link
Contributor

Fix issue #1878

Copy link

netlify bot commented Dec 15, 2023

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 29fdf8d
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/657c8b0f5cf72c0007120ffb
😎 Deploy Preview https://deploy-preview-2093.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Dec 15, 2023

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
16 3.08 MB → 3.08 MB (+20 B) +0.00%
Changeset
File Δ Size
src/components/budget/rollover/RolloverComponents.tsx 📈 +50 B (+0.30%) 16.34 kB → 16.39 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
static/js/wide-components.chunk.js 114.96 kB → 114.98 kB (+20 B) +0.02%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/main.js 1.26 MB 0%
static/js/665.chunk.js 824.28 kB 0%
static/media/Inter-italic.var.woff2 239.29 kB 0%
static/media/Inter-roman.var.woff2 221.86 kB 0%
static/js/444.chunk.js 156.11 kB 0%
static/js/231.chunk.js 117.38 kB 0%
static/js/reports.chunk.js 76.33 kB 0%
static/js/narrow-components.chunk.js 51.17 kB 0%
static/js/226.chunk.js 28.94 kB 0%
static/js/473.chunk.js 13 kB 0%
static/js/resize-observer-polyfill.chunk.js 8.88 kB 0%
static/css/main.css 7.41 kB 0%
asset-manifest.json 2.07 kB 0%
index.html 1.66 kB 0%
static/media/browser-server.js 911 B 0%

Copy link
Contributor

github-actions bot commented Dec 15, 2023

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
2 2.23 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.23 MB 0%
xfo.xfo.kcab.worker.js 1014.46 kB 0%

@youngcw
Copy link
Member

youngcw commented Dec 15, 2023

fyi, if you say "fixes #xxxx" or "resolves #xxxx" in your description github will auto link the issue. That just helps reduce the extra work of manually linking or closing issues.

@youngcw youngcw linked an issue Dec 15, 2023 that may be closed by this pull request
1 task
Copy link
Member

@youngcw youngcw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this. Its been around longer than it should

@youngcw youngcw merged commit a5557ca into actualbudget:master Dec 15, 2023
19 checks passed
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved ✨ Merged Pull Request has been merged successfully labels Dec 15, 2023
@HansiWursti HansiWursti deleted the fix branch December 22, 2023 13:11
FlorianLang06 pushed a commit to FlorianLang06/actual that referenced this pull request Mar 7, 2024
* Fix issue 1878

* Add release notes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Missing last divider bar single category budget drop down
2 participants