Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added BG Color to view to fix Issue 2089 #2092

Merged
merged 2 commits into from
Dec 15, 2023

Conversation

HansiWursti
Copy link
Contributor

@HansiWursti HansiWursti commented Dec 15, 2023

Hi,

this should fix issue #2089

In the light theme the white bg color is also wrong but not that visible

Thank you!

Copy link

netlify bot commented Dec 15, 2023

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit eaa5058
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/657c72c77c420100082db648
😎 Deploy Preview https://deploy-preview-2092.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Dec 15, 2023

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
16 3.09 MB → 3.08 MB (-1.26 kB) -0.04%
Changeset
File Δ Size
src/components/FinancesApp.tsx 📈 +67 B (+0.43%) 15.1 kB → 15.17 kB
src/components/accounts/MobileAccount.js 📉 -246 B (-3.42%) 7.03 kB → 6.79 kB
../loot-core/src/client/queries.ts 📉 -643 B (-8.79%) 7.14 kB → 6.51 kB
src/components/accounts/MobileAccountDetails.js 📉 -3.88 kB (-43.34%) 8.96 kB → 5.08 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

Asset File Size % Changed
static/js/narrow-components.chunk.js 52.08 kB → 51.17 kB (-935 B) -1.75%
static/js/main.js 1.26 MB → 1.26 MB (-358 B) -0.03%

Unchanged

Asset File Size % Changed
static/js/665.chunk.js 824.28 kB 0%
static/media/Inter-italic.var.woff2 239.29 kB 0%
static/media/Inter-roman.var.woff2 221.86 kB 0%
static/js/444.chunk.js 156.11 kB 0%
static/js/231.chunk.js 117.38 kB 0%
static/js/wide-components.chunk.js 114.96 kB 0%
static/js/reports.chunk.js 76.33 kB 0%
static/js/226.chunk.js 28.94 kB 0%
static/js/473.chunk.js 13 kB 0%
static/js/resize-observer-polyfill.chunk.js 8.88 kB 0%
static/css/main.css 7.41 kB 0%
asset-manifest.json 2.07 kB 0%
index.html 1.66 kB 0%
static/media/browser-server.js 911 B 0%

Copy link
Contributor

github-actions bot commented Dec 15, 2023

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
2 2.23 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.23 MB 0%
xfo.xfo.kcab.worker.js 1014.46 kB 0%

@youngcw
Copy link
Member

youngcw commented Dec 15, 2023

I think you mean fixes #2089. Looks good though

@youngcw youngcw linked an issue Dec 15, 2023 that may be closed by this pull request
1 task
@HansiWursti HansiWursti changed the title Added BG Color to view to fix Issue 2289 Added BG Color to view to fix Issue 2089 Dec 15, 2023
@youngcw youngcw merged commit 0bf587b into actualbudget:master Dec 15, 2023
19 checks passed
@trafico-bot trafico-bot bot added ✅ Approved ✨ Merged Pull Request has been merged successfully and removed 🔍 Ready for Review ✨ Merged Pull Request has been merged successfully labels Dec 15, 2023
@HansiWursti HansiWursti deleted the fix-bg-sidebar branch December 15, 2023 15:53
FlorianLang06 pushed a commit to FlorianLang06/actual that referenced this pull request Mar 7, 2024
* Added BG Color to view to fix Issue 2289

* add release notes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Dark Mode White background when pinning the side bar
2 participants