Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ (TypeScript) fix strictFunctionTypes violations (pt 5) #2072

Merged
merged 13 commits into from
Jan 6, 2024

Conversation

MatissJanis
Copy link
Member

Fixing next batch of issues that become visible when enabling strictFunctionTypes.

Final PR in the series.

Copy link
Contributor

github-actions bot commented Dec 12, 2023

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
15 3.09 MB 0%
Changeset
File Δ Size
src/hooks/useActions.ts 📈 +153 B (+36.69%) 417 B → 570 B
src/components/autocomplete/SavedFilterAutocomplete.tsx 📉 -98 B (-4.46%) 2.14 kB → 2.05 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/main.js 1.43 MB 0%
static/js/665.chunk.js 824.28 kB 0%
static/media/Inter-italic.var.woff2 239.29 kB 0%
static/media/Inter-roman.var.woff2 221.86 kB 0%
static/js/231.chunk.js 117.38 kB 0%
static/js/wide-components.chunk.js 113.08 kB 0%
static/js/reports.chunk.js 78.28 kB 0%
static/js/narrow-components.chunk.js 45.2 kB 0%
static/js/553.chunk.js 28.56 kB 0%
static/js/473.chunk.js 13 kB 0%
static/js/resize-observer-polyfill.chunk.js 8.88 kB 0%
static/css/main.css 7.41 kB 0%
asset-manifest.json 1.92 kB 0%
index.html 1.66 kB 0%
static/media/browser-server.js 911 B 0%

Copy link
Contributor

github-actions bot commented Dec 12, 2023

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
2 2.23 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.24 MB 0%
xfo.xfo.kcab.worker.js 1014.46 kB 0%

@MatissJanis MatissJanis marked this pull request as ready for review December 12, 2023 15:36
Base automatically changed from matiss/strict-ts-5 to master December 22, 2023 21:20
Copy link

netlify bot commented Dec 22, 2023

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 9b07e8d
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/65994c48b1970a000882b7c3
😎 Deploy Preview https://deploy-preview-2072.demo.actualbudget.org/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@MatissJanis MatissJanis changed the title ♻️ (TypeScript) fix strictFunctionTypes violations (pt 5) [WIP] ♻️ (TypeScript) fix strictFunctionTypes violations (pt 5) Dec 29, 2023
@MatissJanis
Copy link
Member Author

MatissJanis commented Dec 29, 2023

WIP: need to re-revert #2128 before merging this PR

@MatissJanis MatissJanis changed the title [WIP] ♻️ (TypeScript) fix strictFunctionTypes violations (pt 5) ♻️ (TypeScript) fix strictFunctionTypes violations (pt 5) Jan 6, 2024
@MatissJanis MatissJanis merged commit 7a40a64 into master Jan 6, 2024
19 checks passed
@MatissJanis MatissJanis deleted the matiss/strict-ts-6 branch January 6, 2024 12:58
@trafico-bot trafico-bot bot added the ✨ Merged Pull Request has been merged successfully label Jan 6, 2024
@trafico-bot trafico-bot bot removed the ✅ Approved label Jan 6, 2024
FlorianLang06 pushed a commit to FlorianLang06/actual that referenced this pull request Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants