♻️ (TypeScript) fix strictFunctionTypes violations (pt 3) #2070
Conversation
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| e: KeyboardEvent<HTMLInputElement>, | ||
| prevOnKeyDown?: ComponentProps<typeof Input>['onKeyDown'], | ||
| ) { | ||
| // @ts-expect-error We're missing `target.value` on KeyboardEvent |
There was a problem hiding this comment.
I think we can use currentTarget here
There was a problem hiding this comment.
Good idea. That works just fine :)
trafico-bot
bot
added
✨ Merged
Fixing next batch of issues that become visible when enabling
strictFunctionTypes.