Renaming variables for reports files #2069
Conversation
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
| { description: '3 months', name: 2 }, | ||
| { description: '6 months', name: 5 }, | ||
| { description: '1 year', name: 11 }, | ||
| { description: 'This month', name: 0 }, |
There was a problem hiding this comment.
❓ question: is this actually correct?
If I open the page on 2nd of January: will it show only 2 days worth of data (1st - 2nd Jan)? Or would it show the last ~30 days?
There was a problem hiding this comment.
It's by month where monthDiff = 0. So it would show only 2 days. I plan to add an interval selector where you can view data by day or week or year etc. At that point, I'll also add new range options (based on which interval you select) like "last 30 days", "last 7 days", "this week", "last week", etc.
Co-authored-by: Matiss Janis Aboltins <[email protected]>
trafico-bot
bot
added
✨ Merged
* work * notes * error fixes * updates * card fix * fix filters * splitting PR work * notes * fixes * lint fix * Update upcoming-release-notes/2069.md Co-authored-by: Matiss Janis Aboltins <[email protected]> --------- Co-authored-by: Matiss Janis Aboltins <[email protected]>
This is used to rename variable with ambiguous names across all files in reports section.