Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new types for reports files #2067

Merged
merged 8 commits into from
Dec 12, 2023
Merged

Add new types for reports files #2067

merged 8 commits into from
Dec 12, 2023

Conversation

carkom
Copy link
Contributor

@carkom carkom commented Dec 11, 2023

Adding types to prep for typescript updates in coming PR.

Copy link

netlify bot commented Dec 11, 2023

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit b92f134
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/657792408dc67400084910c9
😎 Deploy Preview https://deploy-preview-2067.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

data={data[splitData].filter(i =>
!empty ? i[balanceTypeOp] !== 0 : true,
)}
data={data[splitData]}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needed updates due to type additions

{data[splitData]
.filter(i => (!empty ? i[balanceTypeOp] !== 0 : true))
.map((entry, index) => (
{data[splitData].map((entry, index) => (
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

Copy link
Contributor

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
16 3.08 MB → 3.08 MB (-1.28 kB) -0.04%
Changeset
File Δ Size
src/components/reports/spreadsheets/default-spreadsheet.tsx 📈 +122 B (+2.96%) 4.02 kB → 4.14 kB
src/components/reports/spreadsheets/grouped-spreadsheet.ts 📈 +74 B (+2.01%) 3.59 kB → 3.66 kB
src/components/reports/ReportOptions.tsx 📈 +26 B (+0.69%) 3.67 kB → 3.7 kB
src/components/reports/reports/CustomReport.js 📈 +80 B (+0.50%) 15.53 kB → 15.6 kB
src/components/reports/ReportTableHeader.tsx 📈 +6 B (+0.19%) 3.16 kB → 3.17 kB
src/components/reports/graphs/DonutGraph.tsx 📉 -59 B (-1.28%) 4.49 kB → 4.43 kB
src/components/reports/ChooseGraph.tsx 📉 -72 B (-1.74%) 4.04 kB → 3.97 kB
src/components/reports/graphs/BarGraph.tsx 📉 -163 B (-1.90%) 8.37 kB → 8.21 kB
src/components/accounts/MobileAccount.js 📉 -246 B (-3.42%) 7.03 kB → 6.79 kB
../loot-core/src/client/queries.ts 📉 -643 B (-8.79%) 7.14 kB → 6.51 kB
src/components/accounts/MobileAccountDetails.js 📉 -3.88 kB (-43.34%) 8.96 kB → 5.08 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
static/js/reports.chunk.js 76.17 kB → 76.19 kB (+15 B) +0.02%

Smaller

Asset File Size % Changed
static/js/narrow-components.chunk.js 52.08 kB → 51.17 kB (-935 B) -1.75%
static/js/main.js 1.26 MB → 1.26 MB (-395 B) -0.03%

Unchanged

Asset File Size % Changed
static/js/665.chunk.js 824.28 kB 0%
static/media/Inter-italic.var.woff2 239.29 kB 0%
static/media/Inter-roman.var.woff2 221.86 kB 0%
static/js/444.chunk.js 156.11 kB 0%
static/js/231.chunk.js 117.38 kB 0%
static/js/wide-components.chunk.js 114.8 kB 0%
static/js/226.chunk.js 28.94 kB 0%
static/js/473.chunk.js 13 kB 0%
static/js/resize-observer-polyfill.chunk.js 8.88 kB 0%
static/css/main.css 7.41 kB 0%
asset-manifest.json 2.07 kB 0%
index.html 1.66 kB 0%
static/media/browser-server.js 911 B 0%

Copy link
Contributor

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
2 2.23 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.23 MB 0%
xfo.xfo.kcab.worker.js 1014.46 kB 0%

Copy link
Member

@MatissJanis MatissJanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Much easier to review!

@carkom carkom merged commit cd2d186 into actualbudget:master Dec 12, 2023
19 checks passed
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved labels Dec 12, 2023
@carkom carkom deleted the addTypes branch December 12, 2023 00:31
FlorianLang06 pushed a commit to FlorianLang06/actual that referenced this pull request Mar 7, 2024
* work

* notes

* error fixes

* updates

* card fix

* fix filters

* splitting PR work

* notes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants