Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API – Return Hidden for Category and CategoryGroup #2062

Merged
merged 13 commits into from
Dec 15, 2023

Conversation

ioslife
Copy link
Contributor

@ioslife ioslife commented Dec 11, 2023


category: API Features
authors: iOSLife

Adds a property to the returned items in the API for category and categoryGroup to inform if it is hidden.

Not sure if there are more changes needed for this functionality, but willing to make them if I can get some direction.

Copy link

netlify bot commented Dec 11, 2023

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 7653727
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/657c93c9fc5e3d00085c58e0
😎 Deploy Preview https://deploy-preview-2062.demo.actualbudget.org/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Dec 11, 2023

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
16 3.08 MB → 3.08 MB (+20 B) +0.00%
Changeset
File Δ Size
../loot-core/src/client/actions/queries.ts 📈 +28 B (+0.28%) 9.9 kB → 9.93 kB
src/components/budget/index.tsx 📈 +17 B (+0.10%) 17.25 kB → 17.27 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
static/js/main.js 1.26 MB → 1.26 MB (+11 B) +0.00%
static/js/wide-components.chunk.js 114.98 kB → 114.99 kB (+9 B) +0.01%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/665.chunk.js 824.28 kB 0%
static/media/Inter-italic.var.woff2 239.29 kB 0%
static/media/Inter-roman.var.woff2 221.86 kB 0%
static/js/444.chunk.js 156.11 kB 0%
static/js/231.chunk.js 117.38 kB 0%
static/js/reports.chunk.js 76.33 kB 0%
static/js/narrow-components.chunk.js 51.17 kB 0%
static/js/226.chunk.js 28.94 kB 0%
static/js/473.chunk.js 13 kB 0%
static/js/resize-observer-polyfill.chunk.js 8.88 kB 0%
static/css/main.css 7.41 kB 0%
asset-manifest.json 2.07 kB 0%
index.html 1.66 kB 0%
static/media/browser-server.js 911 B 0%

Copy link
Contributor

github-actions bot commented Dec 11, 2023

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
2 2.23 MB → 2.23 MB (+174 B) +0.01%
Changeset
File Δ Size
packages/loot-core/src/server/api-models.ts 📈 +293 B (+12.97%) 2.21 kB → 2.49 kB
packages/loot-core/src/server/api.ts 📈 +33 B (+0.19%) 17.04 kB → 17.07 kB
packages/loot-core/src/server/main.ts 📈 +44 B (+0.07%) 63.49 kB → 63.53 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
kcab.worker.js 1.23 MB → 1.24 MB (+174 B) +0.01%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
xfo.xfo.kcab.worker.js 1014.46 kB 0%

@ioslife ioslife changed the title [Maintenance] ESLint - prefer-const on loot-core server (#2032) API – Return Hidden for Category and CategoryGroup Dec 11, 2023
@ioslife ioslife marked this pull request as draft December 11, 2023 13:16
@ioslife ioslife marked this pull request as ready for review December 11, 2023 14:16
MatissJanis
MatissJanis previously approved these changes Dec 14, 2023
Copy link
Member

@MatissJanis MatissJanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall: LGTM! Let me know what you think about the nitpick.

Thanks!

packages/loot-core/src/types/server-handlers.d.ts Outdated Show resolved Hide resolved
@ioslife
Copy link
Contributor Author

ioslife commented Dec 14, 2023

@MatissJanis adding your suggestion and updated branch with master

Copy link
Member

@MatissJanis MatissJanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MatissJanis MatissJanis merged commit af9efa0 into actualbudget:master Dec 15, 2023
19 checks passed
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved labels Dec 15, 2023
FlorianLang06 pushed a commit to FlorianLang06/actual that referenced this pull request Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants