Mobile payees and rules pages

[joel-jeremy]

No description provided.

[netlify]

✅ Deploy Preview for actualbudget ready!

Name	Link
🔨 Latest commit	8b58953
🔍 Latest deploy log	https://app.netlify.com/sites/actualbudget/deploys/65a1794bdda6c80008eb222c
😎 Deploy Preview	https://deploy-preview-2037.demo.actualbudget.org/
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[github-actions]

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
10	5.07 MB → 5.07 MB (+755 B)	+0.01%

Changeset

File	Δ	Size
src/components/common/Search.tsx	📈 +68 B (+4.30%)	1.55 kB → 1.61 kB
src/components/FinancesApp.tsx	📈 +451 B (+4.27%)	10.3 kB → 10.75 kB
src/components/ManageRules.tsx	📈 +202 B (+2.36%)	8.36 kB → 8.56 kB
src/components/schedules/ScheduleLink.tsx	📈 +37 B (+1.67%)	2.16 kB → 2.2 kB
src/components/payees/ManagePayees.jsx	📈 +121 B (+1.42%)	8.34 kB → 8.46 kB
src/components/modals/EditRule.jsx	📉 -100 B (-0.37%)	26.72 kB → 26.62 kB
src/components/mobile/MobileNavTabs.tsx	📉 -24 B (-0.56%)	4.16 kB → 4.13 kB

View detailed bundle breakdown

Added

Asset	File Size	% Changed
static/js/index-JLJRCy5H.js	0 B → 2.63 MB (+2.63 MB)	-
static/js/ReportRouter-L53n6_9j.js	0 B → 1.94 MB (+1.94 MB)	-
static/js/wide-OztfwiQ3.js	0 B → 236.3 kB (+236.3 kB)	-
static/js/BackgroundImage-H3AKuH__.js	0 B → 122.29 kB (+122.29 kB)	-
static/js/narrow-7pDno5-U.js	0 B → 82.17 kB (+82.17 kB)	-
static/js/FiltersMenu-wIbVh7S3.js	0 B → 28.92 kB (+28.92 kB)	-
static/js/BalanceTooltip-lylr6QLz.js	0 B → 6.07 kB (+6.07 kB)	-
static/js/ButtonLink-4JAxBJ3r.js	0 B → 379 B (+379 B)	-

Removed

Asset	File Size	% Changed
static/js/index-VeCzGiqD.js	2.63 MB → 0 B (-2.63 MB)	-100%
static/js/ReportRouter-_eIRirAl.js	1.94 MB → 0 B (-1.94 MB)	-100%
static/js/wide-XL9tQpTV.js	236.3 kB → 0 B (-236.3 kB)	-100%
static/js/BackgroundImage-P1150fjc.js	122.29 kB → 0 B (-122.29 kB)	-100%
static/js/narrow-tjSR1AMi.js	82.17 kB → 0 B (-82.17 kB)	-100%
static/js/FiltersMenu-8JbemJtz.js	28.92 kB → 0 B (-28.92 kB)	-100%
static/js/BalanceTooltip-bvTJe4YM.js	6.07 kB → 0 B (-6.07 kB)	-100%
static/js/ButtonLink-aJUOQwYy.js	379 B → 0 B (-379 B)	-100%

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
static/js/indexeddb-main-thread-worker-e59fee74-bhyX5Ad6.js	13.5 kB	0%
static/js/resize-observer-6FaCDon1.js	18.37 kB	0%

[github-actions]

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
1	1.23 MB	0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
kcab.worker.js	1.23 MB	0%

[youngcw]

This will be great.

Probably for a different PR, but the formatting on the rules page needs some fixing for the small size.

[joel-jeremy]

I have made a change to make the link schedule rule to wrap the schedule data on smaller screens

[youngcw]

There still is a lot of space on the left side before the pills even start

[joel-jeremy]

Oh I see. I think that is for displaying the pre or post stages. But yeah, a rules page specifically catered for mobile devices would be great but that should be done in a different PR.

[carkom]

What do you think of copying the "+" from accounts page format for the rules page? Currently with 3 rules, the "create new rule" button is behind the main menu and there's no ability to scroll down so that the menu auto hides. This makes the new rules button inaccessible in my current circumstance.

[youngcw]

The new rule button seems to be covered by the footer in a lot of situations.

Thats the only big issue Im seeing.

[github-actions]

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

[MatissJanis]

👋 The rules & payees views are pretty hard to use on mobile.

Rules:

Screen.Recording.2024-01-13.at.11.12.17.mov

• "add rule" button is basically unclickable because of the footer
• rules modal style for some elements is broken
• on smaller screens the rules modal will be comletely broken (there is no minHeight for the content of the modal)
• the footer keeps scrolling up&down when I scroll inside the modal
• the autocomplete component used in rules modal doesn't really work on mobile; plus it's tiny

Payees:

• same problem as rules - the footer overlays the last items in the list making them unusable
• same problem as rules - modal content does not have minHeight
• same problem as rules - autocomplete

[github-actions]

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

[github-actions]

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

[github-actions]

This PR was closed because it has been stalled for 5 days with no activity.