[WIP] ♻️ (typescript) making Modals typing more strict

[MatissJanis]

Closes #1940

[netlify]

✅ Deploy Preview for actualbudget ready!

Name	Link
🔨 Latest commit	c876682
🔍 Latest deploy log	https://app.netlify.com/sites/actualbudget/deploys/656e48a084098d0007038f6c
😎 Deploy Preview	https://deploy-preview-2030.demo.actualbudget.org
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[github-actions]

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
16	3.08 MB	0%

Changeset

File	Δ	Size
src/components/reports/chart-theme.js	🆕 +4.05 kB	0 B → 4.05 kB
src/components/reports/util.js	🆕 +1.11 kB	0 B → 1.11 kB
../loot-core/src/client/actions/modals.ts	📉 -82 B (-12.63%)	649 B → 567 B
src/components/reports/chart-theme.ts	🔥 -4.05 kB (-100%)	4.05 kB → 0 B
src/components/reports/util.ts	🔥 -1.11 kB (-100%)	1.11 kB → 0 B

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
static/js/main.js	1.26 MB	0%
static/js/665.chunk.js	824.28 kB	0%
static/media/Inter-italic.var.woff2	239.29 kB	0%
static/media/Inter-roman.var.woff2	221.86 kB	0%
static/js/444.chunk.js	156.11 kB	0%
static/js/231.chunk.js	117.37 kB	0%
static/js/wide-components.chunk.js	114.1 kB	0%
static/js/reports.chunk.js	74.98 kB	0%
static/js/narrow-components.chunk.js	52.71 kB	0%
static/js/226.chunk.js	28.82 kB	0%
static/js/473.chunk.js	13 kB	0%
static/js/resize-observer-polyfill.chunk.js	8.88 kB	0%
static/css/main.css	7.41 kB	0%
asset-manifest.json	2.07 kB	0%
index.html	1.66 kB	0%
static/media/browser-server.js	911 B	0%

[github-actions]

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
2	2.22 MB	0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
kcab.worker.js	1.23 MB	0%
xfo.xfo.kcab.worker.js	1014.46 kB	0%

[MatissJanis]

This is much more difficult than anticipated. Won't be picking it up anytime soon again.