Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ (typescript) adding strict typings to utils.ts #2023

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

MatissJanis
Copy link
Member

Adding more strict typings to utils.ts and some of its dependencies (where necessary).

Copy link

netlify bot commented Dec 3, 2023

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit d5b4faf
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/656cda5e27c90300086a04ce
😎 Deploy Preview https://deploy-preview-2023.demo.actualbudget.org/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Dec 3, 2023

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
16 3.08 MB → 3.08 MB (-77 B) -0.00%
Changeset
File Δ Size
../loot-core/src/shared/transactions.ts 📉 -17 B (-0.21%) 8.05 kB → 8.03 kB
src/components/filters/FiltersMenu.js 📉 -187 B (-0.75%) 24.26 kB → 24.08 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

Asset File Size % Changed
static/js/226.chunk.js 28.89 kB → 28.82 kB (-67 B) -0.23%
static/js/main.js 1.26 MB → 1.26 MB (-10 B) -0.00%

Unchanged

Asset File Size % Changed
static/js/665.chunk.js 824.28 kB 0%
static/media/Inter-italic.var.woff2 239.29 kB 0%
static/media/Inter-roman.var.woff2 221.86 kB 0%
static/js/444.chunk.js 156.11 kB 0%
static/js/231.chunk.js 117.37 kB 0%
static/js/wide-components.chunk.js 113.85 kB 0%
static/js/reports.chunk.js 74.98 kB 0%
static/js/narrow-components.chunk.js 52.61 kB 0%
static/js/473.chunk.js 13 kB 0%
static/js/resize-observer-polyfill.chunk.js 8.88 kB 0%
static/css/main.css 7.41 kB 0%
asset-manifest.json 2.07 kB 0%
index.html 1.66 kB 0%
static/media/browser-server.js 911 B 0%

Copy link
Contributor

github-actions bot commented Dec 3, 2023

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
2 2.22 MB → 2.22 MB (-19 B) -0.00%
Changeset
File Δ Size
packages/loot-core/src/mocks/budget.ts 📉 -11 B (-0.04%) 28.5 kB → 28.49 kB
packages/loot-core/src/shared/transactions.ts 📉 -17 B (-0.21%) 8.05 kB → 8.03 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

Asset File Size % Changed
kcab.worker.js 1.23 MB → 1.23 MB (-19 B) -0.00%

Unchanged

Asset File Size % Changed
xfo.xfo.kcab.worker.js 1014.46 kB 0%

@MatissJanis MatissJanis marked this pull request as ready for review December 3, 2023 19:45
@MatissJanis MatissJanis merged commit 7174fcc into master Dec 6, 2023
19 checks passed
@MatissJanis MatissJanis deleted the matiss/typescript-utils branch December 6, 2023 08:22
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved labels Dec 6, 2023
FlorianLang06 pushed a commit to FlorianLang06/actual that referenced this pull request Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants