Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cashflow.js -> Cashflow.tsx #2005

Merged
merged 12 commits into from
Dec 12, 2023
Merged

Conversation

lucasboebel
Copy link
Contributor

@lucasboebel lucasboebel commented Dec 2, 2023

first pull request, feedback appreciated :)

Copy link

netlify bot commented Dec 2, 2023

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit dc8bd6e
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/6577eaa0dc3d0900088bd4c0
😎 Deploy Preview https://deploy-preview-2005.demo.actualbudget.org/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Dec 2, 2023

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
16 3.08 MB → 3.08 MB (+26 B) +0.00%
Changeset
File Δ Size
src/components/reports/reports/CashFlow.tsx 🆕 +8.45 kB 0 B → 8.45 kB
src/components/reports/reports/CashFlow.js 🔥 -8.44 kB (-100%) 8.44 kB → 0 B
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
static/js/reports.chunk.js 76.19 kB → 76.21 kB (+26 B) +0.03%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/main.js 1.26 MB 0%
static/js/665.chunk.js 824.28 kB 0%
static/media/Inter-italic.var.woff2 239.29 kB 0%
static/media/Inter-roman.var.woff2 221.86 kB 0%
static/js/444.chunk.js 156.11 kB 0%
static/js/231.chunk.js 117.38 kB 0%
static/js/wide-components.chunk.js 114.8 kB 0%
static/js/narrow-components.chunk.js 51.17 kB 0%
static/js/226.chunk.js 28.94 kB 0%
static/js/473.chunk.js 13 kB 0%
static/js/resize-observer-polyfill.chunk.js 8.88 kB 0%
static/css/main.css 7.41 kB 0%
asset-manifest.json 2.07 kB 0%
index.html 1.66 kB 0%
static/media/browser-server.js 911 B 0%

Copy link
Contributor

github-actions bot commented Dec 2, 2023

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
2 2.23 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.23 MB 0%
xfo.xfo.kcab.worker.js 1014.46 kB 0%

@MatissJanis
Copy link
Member

👋 Just checking in: would you like this PR to be reviewed? It's currently in draft, so double checking.

@lucasboebel lucasboebel marked this pull request as ready for review December 7, 2023 21:09
@lucasboebel
Copy link
Contributor Author

👋 Just checking in: would you like this PR to be reviewed? It's currently in draft, so double checking.

Yes please! Just marked it ready for review, my bad

@trafico-bot trafico-bot bot added ⚠️ Changes requested Pull Request needs changes before it can be reviewed again 🔍 Ready for Review and removed 🔍 Ready for Review ⚠️ Changes requested Pull Request needs changes before it can be reviewed again labels Dec 9, 2023
@youngcw
Copy link
Member

youngcw commented Dec 11, 2023

Can you look into why the tests are failing?

@MatissJanis MatissJanis merged commit 36914ab into actualbudget:master Dec 12, 2023
19 checks passed
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved labels Dec 12, 2023
FlorianLang06 pushed a commit to FlorianLang06/actual that referenced this pull request Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants