Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Goals]: Sort the priorities properly #2000

Merged
merged 2 commits into from
Dec 1, 2023
Merged

[Goals]: Sort the priorities properly #2000

merged 2 commits into from
Dec 1, 2023

Conversation

youngcw
Copy link
Member

@youngcw youngcw commented Nov 30, 2023

Priority sorting was using alphabetical sorting instead of numeric sorting. This fixes it to sort as expected.

Fixes #1999

Copy link

netlify bot commented Nov 30, 2023

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit d8d81a4
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/656920d7d8a8d6000821a569
😎 Deploy Preview https://deploy-preview-2000.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Nov 30, 2023

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
16 3.08 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/main.js 1.17 MB 0%
static/js/665.chunk.js 824.28 kB 0%
static/media/Inter-italic.var.woff2 239.29 kB 0%
static/media/Inter-roman.var.woff2 221.86 kB 0%
static/js/444.chunk.js 156.11 kB 0%
static/js/821.chunk.js 121.15 kB 0%
static/js/231.chunk.js 117.37 kB 0%
static/js/wide-components.chunk.js 113.85 kB 0%
static/js/reports.chunk.js 74.96 kB 0%
static/js/narrow-components.chunk.js 52.93 kB 0%
static/js/473.chunk.js 13 kB 0%
static/js/resize-observer-polyfill.chunk.js 8.88 kB 0%
static/css/main.css 7.41 kB 0%
asset-manifest.json 2.07 kB 0%
index.html 1.66 kB 0%
static/media/browser-server.js 911 B 0%

Copy link
Contributor

github-actions bot commented Nov 30, 2023

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
2 2.22 MB → 2.22 MB (+27 B) +0.00%
Changeset
File Δ Size
packages/loot-core/src/server/budget/goaltemplates.ts 📈 +44 B (+0.20%) 21.05 kB → 21.09 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
kcab.worker.js 1.23 MB → 1.23 MB (+27 B) +0.00%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
xfo.xfo.kcab.worker.js 1014.46 kB 0%

Copy link
Contributor

@shall0pass shall0pass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@youngcw youngcw merged commit c96782d into actualbudget:master Dec 1, 2023
18 of 19 checks passed
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved labels Dec 1, 2023
@youngcw youngcw deleted the youngcw/fix_template_priority_sort branch January 8, 2024 16:48
FlorianLang06 pushed a commit to FlorianLang06/actual that referenced this pull request Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Goal template priorities >= 10 don't work as expected
2 participants