Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom report updates #1996

Closed
wants to merge 58 commits into from
Closed

Conversation

carkom
Copy link
Contributor

@carkom carkom commented Nov 30, 2023

  • Updating the custom report table scrolling behavior.
  • Fixing and adding typescript to most the files
  • Updating variable names to be more understandable and explicit
  • Introducing Live/Static date choice

Copy link

netlify bot commented Nov 30, 2023

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 50f67a7
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/657193b264a3b700081e1f1d
😎 Deploy Preview https://deploy-preview-1996.demo.actualbudget.org/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Nov 30, 2023

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
16 3.08 MB → 3.08 MB (+2.68 kB) +0.08%
Changeset
File Δ Size
src/components/manager/Import.js 🆕 +4.77 kB 0 B → 4.77 kB
src/components/reports/ReportSummary.tsx 🆕 +4.77 kB 0 B → 4.77 kB
src/components/budget/BudgetTotals.js 🆕 +4.69 kB 0 B → 4.69 kB
src/components/manager/WelcomeScreen.js 🆕 +3.81 kB 0 B → 3.81 kB
src/components/reports/ReportTableRow.tsx 🆕 +3.15 kB 0 B → 3.15 kB
src/components/reports/ReportTableInner.tsx 🆕 +2.41 kB 0 B → 2.41 kB
src/components/reports/ReportLegend.tsx 🆕 +2.09 kB 0 B → 2.09 kB
src/components/reports/ColumnPrimary.tsx 🆕 +1.54 kB 0 B → 1.54 kB
src/components/reports/ColumnScrollbar.tsx 🆕 +1.32 kB 0 B → 1.32 kB
src/components/reports/DateRange.js 🆕 +1.03 kB 0 B → 1.03 kB
src/components/gocardless/GoCardlessLink.js 🆕 +922 B 0 B → 922 B
src/components/reports/ModeButton.tsx 🆕 +893 B 0 B → 893 B
src/components/reports/TableRowIndex.tsx 🆕 +782 B 0 B → 782 B
src/components/reports/useReport.js 🆕 +542 B 0 B → 542 B
src/components/reports/ReportTable.tsx 📈 +2.65 kB (+241.08%) 1.1 kB → 3.75 kB
src/components/reports/ReportTableTotals.tsx 📈 +1.34 kB (+33.67%) 3.98 kB → 5.32 kB
src/components/reports/ChooseGraph.tsx 📈 +1.33 kB (+32.96%) 4.04 kB → 5.38 kB
src/components/reports/ReportTableHeader.tsx 📈 +473 B (+14.62%) 3.16 kB → 3.62 kB
src/components/reports/ReportSidebar.js 📈 +1.13 kB (+6.18%) 18.25 kB → 19.38 kB
src/components/reports/spreadsheets/grouped-spreadsheet.ts 📈 +203 B (+5.52%) 3.59 kB → 3.79 kB
src/components/reports/spreadsheets/default-spreadsheet.tsx 📈 +112 B (+2.72%) 4.02 kB → 4.13 kB
src/components/reports/ReportOptions.tsx 📈 +66 B (+1.75%) 3.67 kB → 3.74 kB
src/components/reports/CategorySelector.tsx 📈 +180 B (+1.61%) 10.94 kB → 11.12 kB
src/components/reports/spreadsheets/makeQuery.ts 📈 +42 B (+1.53%) 2.67 kB → 2.71 kB
src/components/reports/reports/CustomReport.js 📈 +177 B (+1.11%) 15.53 kB → 15.7 kB
src/components/reports/graphs/BarGraph.tsx 📈 +16 B (+0.19%) 8.37 kB → 8.39 kB
src/components/reports/graphs/DonutGraph.tsx 📈 +8 B (+0.17%) 4.49 kB → 4.5 kB
src/components/transactions/TransactionsTable.js 📉 -42 B (-0.06%) 67.59 kB → 67.55 kB
src/components/schedules/SchedulesTable.tsx 📉 -38 B (-0.29%) 12.81 kB → 12.77 kB
src/components/transactions/MobileTransaction.js 📉 -174 B (-0.37%) 46.14 kB → 45.97 kB
src/components/accounts/Header.js 📉 -75 B (-0.39%) 18.92 kB → 18.84 kB
src/components/Notifications.tsx 📉 -47 B (-0.54%) 8.47 kB → 8.42 kB
src/components/select/RecurringSchedulePicker.js 📉 -115 B (-0.57%) 19.86 kB → 19.75 kB
src/components/manager/BudgetList.js 📉 -71 B (-0.60%) 11.51 kB → 11.44 kB
src/components/Titlebar.tsx 📉 -119 B (-0.73%) 16 kB → 15.89 kB
src/components/NotesButton.tsx 📉 -44 B (-0.76%) 5.68 kB → 5.63 kB
src/components/util/AmountInput.tsx 📉 -40 B (-0.87%) 4.49 kB → 4.45 kB
src/components/UpdateNotification.tsx 📉 -63 B (-1.24%) 4.96 kB → 4.9 kB
src/components/budget/rollover/budgetsummary/BudgetSummary.tsx 📉 -166 B (-1.45%) 11.17 kB → 11.01 kB
src/components/budget/report/budgetsummary/BudgetSummary.tsx 📉 -166 B (-1.57%) 10.32 kB → 10.16 kB
src/components/autocomplete/SavedFilterAutocomplete.tsx 📉 -45 B (-2.14%) 2.05 kB → 2 kB
src/components/ThemeSelector.tsx 📉 -38 B (-3.26%) 1.14 kB → 1.1 kB
src/components/sidebar/ToggleButton.tsx 📉 -69 B (-5.88%) 1.15 kB → 1.08 kB
src/components/reports/ReportSummary.js 🔥 -6.96 kB (-100%) 6.96 kB → 0 B
src/components/reports/ReportTableList.tsx 🔥 -6.01 kB (-100%) 6.01 kB → 0 B
src/components/manager/Import.tsx 🔥 -4.77 kB (-100%) 4.77 kB → 0 B
src/components/budget/BudgetTotals.tsx 🔥 -4.73 kB (-100%) 4.73 kB → 0 B
src/components/manager/WelcomeScreen.tsx 🔥 -3.82 kB (-100%) 3.82 kB → 0 B
src/components/reports/DateRange.tsx 🔥 -1.07 kB (-100%) 1.07 kB → 0 B
src/components/gocardless/GoCardlessLink.tsx 🔥 -922 B (-100%) 922 B → 0 B
src/components/reports/useReport.tsx 🔥 -542 B (-100%) 542 B → 0 B
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
static/js/reports.chunk.js 76.17 kB → 79.5 kB (+3.32 kB) +4.36%

Smaller

Asset File Size % Changed
static/js/main.js 1.26 MB → 1.26 MB (-408 B) -0.03%
static/js/wide-components.chunk.js 114.8 kB → 114.55 kB (-252 B) -0.21%

Unchanged

Asset File Size % Changed
static/js/665.chunk.js 824.28 kB 0%
static/media/Inter-italic.var.woff2 239.29 kB 0%
static/media/Inter-roman.var.woff2 221.86 kB 0%
static/js/444.chunk.js 156.11 kB 0%
static/js/231.chunk.js 117.38 kB 0%
static/js/narrow-components.chunk.js 51.17 kB 0%
static/js/226.chunk.js 28.94 kB 0%
static/js/473.chunk.js 13 kB 0%
static/js/resize-observer-polyfill.chunk.js 8.88 kB 0%
static/css/main.css 7.41 kB 0%
asset-manifest.json 2.07 kB 0%
index.html 1.66 kB 0%
static/media/browser-server.js 911 B 0%

Copy link
Contributor

github-actions bot commented Nov 30, 2023

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
2 2.22 MB → 2.22 MB (-64 B) -0.00%
Changeset
File Δ Size
packages/loot-core/src/server/budget/goaltemplates.ts 📉 -44 B (-0.20%) 21.09 kB → 21.05 kB
packages/loot-core/src/server/accounts/rules.ts 📉 -55 B (-0.23%) 23.02 kB → 22.96 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

Asset File Size % Changed
kcab.worker.js 1.23 MB → 1.23 MB (-64 B) -0.00%

Unchanged

Asset File Size % Changed
xfo.xfo.kcab.worker.js 1014.46 kB 0%

@youngcw
Copy link
Member

youngcw commented Nov 30, 2023

An extra space has showed up between category groups and categories in the side bar
image

I really like the live/static ranges!

@MatissJanis
Copy link
Member

Screenshot 2023-11-30 at 17 47 50

😬 would you mind splitting the bulletpoints in smaller, more isolated PRs?

@carkom
Copy link
Contributor Author

carkom commented Nov 30, 2023

😬 would you mind splitting the bulletpoints in smaller, more isolated PRs?

This was branched off of the current "optimization" PR. So once that's merged that number should come down by about half. Happy to split this even still.

@MatissJanis
Copy link
Member

Ah, didn't realize that. Ok, lets see what's the changed LOC here when the base PR is merged.

@carkom carkom mentioned this pull request Dec 6, 2023
39 tasks
@carkom
Copy link
Contributor Author

carkom commented Dec 7, 2023

This got completely borked...Re-opening new PR to fix it.

@carkom carkom closed this Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants