-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flickering scroll bar on mobile transaction input (#1782) #1929
Fix flickering scroll bar on mobile transaction input (#1782) #1929
Conversation
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Hi! You might need to pull latest from the actual master branch to pick up some newer changes. That might fix the VRT test failures. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixes the problem for me! Thanks! 🎉
(not merging yet since it looks like @joel-jeremy also started to review)
This also looks good to me! Just waiting for the tests to get fixed. |
Hello there,
This pull request is in response to positive feedback on my suggestion noted on #1782.
It's been a while since I originally added those observations. After a quick test on my end, I can confirm the minor change is still applicable.
EDIT: Noticed a bunch of E2E and VRT failures. If they are legitimate (I'm unsure), perhaps this change needs to be rethought.
Closes #1782