Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flickering scroll bar on mobile transaction input (#1782) #1929

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Fix flickering scroll bar on mobile transaction input (#1782) #1929

merged 1 commit into from
Nov 20, 2023

Conversation

miqh
Copy link
Contributor

@miqh miqh commented Nov 18, 2023

Hello there,

This pull request is in response to positive feedback on my suggestion noted on #1782.

It's been a while since I originally added those observations. After a quick test on my end, I can confirm the minor change is still applicable.

EDIT: Noticed a bunch of E2E and VRT failures. If they are legitimate (I'm unsure), perhaps this change needs to be rethought.


Closes #1782

Copy link

netlify bot commented Nov 18, 2023

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 995be25
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/6559ec35cfb3530008ca0d0e
😎 Deploy Preview https://deploy-preview-1929.demo.actualbudget.org/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Nov 18, 2023

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
16 2.97 MB → 2.97 MB (+19 B) +0.00%
Changeset
File Δ Size
src/components/mobile/MobileAmountInput.js 📈 +45 B (+0.47%) 9.36 kB → 9.4 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
static/js/main.js 1.16 MB → 1.16 MB (+19 B) +0.00%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/665.chunk.js 824.28 kB 0%
static/media/Inter-italic.var.woff2 239.29 kB 0%
static/media/Inter-roman.var.woff2 221.86 kB 0%
static/js/444.chunk.js 156.11 kB 0%
static/js/231.chunk.js 117.37 kB 0%
static/js/wide-components.chunk.js 117.06 kB 0%
static/js/reports.chunk.js 74.37 kB 0%
static/js/narrow-components.chunk.js 52.67 kB 0%
static/js/301.chunk.js 13.31 kB 0%
static/js/473.chunk.js 13 kB 0%
static/js/resize-observer-polyfill.chunk.js 8.88 kB 0%
static/css/main.css 7.41 kB 0%
asset-manifest.json 2.07 kB 0%
index.html 1.66 kB 0%
static/media/browser-server.js 903 B 0%

Copy link
Contributor

github-actions bot commented Nov 18, 2023

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
2 2.22 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.23 MB 0%
xfo.xfo.kcab.worker.js 1014.46 kB 0%

@joel-jeremy
Copy link
Contributor

joel-jeremy commented Nov 18, 2023

Hi! You might need to pull latest from the actual master branch to pick up some newer changes. That might fix the VRT test failures.

Copy link
Member

@MatissJanis MatissJanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the problem for me! Thanks! 🎉

(not merging yet since it looks like @joel-jeremy also started to review)

@joel-jeremy
Copy link
Contributor

This also looks good to me! Just waiting for the tests to get fixed.

@joel-jeremy joel-jeremy merged commit fb2f712 into actualbudget:master Nov 20, 2023
19 checks passed
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved labels Nov 20, 2023
FlorianLang06 pushed a commit to FlorianLang06/actual that referenced this pull request Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: mobile - visual - gray box above input box
3 participants