-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bugfix] Goals: Fix Schedule Infinite loop #1917
Conversation
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
This works on my tests. Thank you! |
Tested on Netlify and it works as expected, thanks for the quick fix! Edit: Do folks usually just use the Netlify preview build for this purpose? On a related note, is there a guide for setting up for local development that I failed to find? I ran into errors after cloning actualbudget/actual and trying to build it (it couldn't find |
@star-szr The netlify builds are perfect for testing things like this without having to deploy your own local service. There are a few cases they can fall short (i.e. api and actual-server interoperability) but for 99% of the PRs, it's amazing. A good start for development would be here: https://actualbudget.org/docs/install/local#installing-actual Instead of cloning the actual-server repo, clone the actualbudget/actual repo, or set up your github to be a fork of the actual repo and sync against that. Then locally -> yarn install && yarn start:browser |
@shall0pass thank you! I had followed those steps to run actual-server just fine but didn't find anything about |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
* logic * release note
Resolves #1913
When the next_date loop is executed, it is iterated in 1 day increments looking for a 'next schedule'. What was happening was the loop had a current date that occurred on a weekend and when we went to get the next occurrence (which should land on the weekend) it was returning that occurrence 1 day before. So each time the loop was set back 1 day before adding the 1 day and we had an infinite loop condition. I've added a check to look for how many days difference the current date and the next date are, and if that value is 0, it will add 3 days instead of 1. I used 3 to resolve the same situation had the schedule landed on a Sunday.