Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate color removal #1911

Merged
merged 2 commits into from
Nov 16, 2023
Merged

Duplicate color removal #1911

merged 2 commits into from
Nov 16, 2023

Conversation

carkom
Copy link
Contributor

@carkom carkom commented Nov 16, 2023

Fixing previous merge due to duplicate colors in theme files.

Copy link

netlify bot commented Nov 16, 2023

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 4a14579
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/6555ea3603a6ed00088fd9b2
😎 Deploy Preview https://deploy-preview-1911.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
16 2.97 MB → 2.97 MB (+1.79 kB) +0.06%
Changeset
File Δ Size
src/components/accounts/MobileAccountDetails.js 📈 +3.19 kB (+41.79%) 7.63 kB → 10.81 kB
src/components/AnimatedRefresh.tsx 📈 +49 B (+7.24%) 677 B → 726 B
src/components/Titlebar.tsx 📈 +1006 B (+6.80%) 14.45 kB → 15.44 kB
src/components/transactions/MobileTransaction.js 📈 +2.06 kB (+4.26%) 48.42 kB → 50.48 kB
src/components/mobile/MobileForms.js 📈 +101 B (+3.46%) 2.85 kB → 2.95 kB
src/components/accounts/MobileAccounts.js 📈 +287 B (+3.04%) 9.21 kB → 9.49 kB
src/components/budget/MobileBudgetTable.js 📈 +1.47 kB (+2.06%) 71.16 kB → 72.63 kB
src/components/settings/index.tsx 📈 +137 B (+1.55%) 8.63 kB → 8.76 kB
src/components/mobile/MobileAmountInput.js 📈 +14 B (+0.15%) 9.35 kB → 9.36 kB
src/components/budget/MobileBudget.js 📉 -7 B (-0.05%) 13 kB → 13 kB
src/components/accounts/MobileAccount.js 📉 -7 B (-0.10%) 6.78 kB → 6.77 kB
src/style/themes/dark.ts 📉 -68 B (-0.69%) 9.6 kB → 9.53 kB
src/style/themes/light.ts 📉 -70 B (-0.71%) 9.57 kB → 9.5 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
static/js/narrow-components.chunk.js 52.15 kB → 53.17 kB (+1.02 kB) +1.96%
static/js/main.js 1.15 MB → 1.15 MB (+786 B) +0.07%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/665.chunk.js 824.28 kB 0%
static/media/Inter-italic.var.woff2 239.29 kB 0%
static/media/Inter-roman.var.woff2 221.86 kB 0%
static/js/444.chunk.js 156.11 kB 0%
static/js/wide-components.chunk.js 127.18 kB 0%
static/js/231.chunk.js 117.37 kB 0%
static/js/reports.chunk.js 74.37 kB 0%
static/js/301.chunk.js 13.31 kB 0%
static/js/473.chunk.js 13 kB 0%
static/js/resize-observer-polyfill.chunk.js 8.88 kB 0%
static/css/main.css 7.41 kB 0%
asset-manifest.json 2.07 kB 0%
index.html 1.66 kB 0%
static/media/browser-server.js 903 B 0%

Copy link
Contributor

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
2 2.22 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.23 MB 0%
xfo.xfo.kcab.worker.js 1014.46 kB 0%

@carkom carkom merged commit 7c0b7a2 into actualbudget:master Nov 16, 2023
19 checks passed
@trafico-bot trafico-bot bot added the ✨ Merged Pull Request has been merged successfully label Nov 16, 2023
@carkom carkom deleted the fixMaster branch November 16, 2023 10:17
FlorianLang06 pushed a commit to FlorianLang06/actual that referenced this pull request Mar 7, 2024
* duplicate color removal

* notes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants