-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sideBar Dark Color changes #1887
Conversation
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@rich-howell , can you do your AA and AAA checks on these? |
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller
Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
For the selected item it now passes :) |
This PR for whatever reason also seems to resolve #1869 |
I feel like the new sidebar colors don't match the other colors. The new sidebar looks way more gray than the other blue hue colors. |
The reason for the move to gray is to create contrast between the tables and the sidebar. "navy700" blends in with split transactions I'm open to suggestions. |
I like that navy900 option. Is that the same as the light theme? |
It is. |
I agree, I like it better as well. Adds some synergy being the same in both themes. |
* sideBar Dark Color changes * notes * VRT updates * test fixes * color fixes * Revert "test fixes" This reverts commit 3c6131b. * Revert "VRT updates" This reverts commit b84d765. * color update * VRT updates * calendar changes * VRT update * notes update * color change * Revert "VRT update" This reverts commit 4c5aba4. * Revert "VRT updates" This reverts commit ba142b0. * VRT updates
Dark Theme sidebar color updates.
Takes place of #1821