Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sideBar Dark Color changes #1887

Merged
merged 21 commits into from
Nov 16, 2023
Merged

sideBar Dark Color changes #1887

merged 21 commits into from
Nov 16, 2023

Conversation

carkom
Copy link
Contributor

@carkom carkom commented Nov 9, 2023

Dark Theme sidebar color updates.

Takes place of #1821

Copy link

netlify bot commented Nov 9, 2023

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit be4cd1f
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/6554b3da889cb00008327843
😎 Deploy Preview https://deploy-preview-1887.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@carkom
Copy link
Contributor Author

carkom commented Nov 9, 2023

@rich-howell , can you do your AA and AAA checks on these?

Copy link
Contributor

github-actions bot commented Nov 9, 2023

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
16 2.88 MB → 2.88 MB (-408 B) -0.01%
Changeset
File Δ Size
src/style/themes/development.ts 📈 +62 B (+0.62%) 9.8 kB → 9.86 kB
src/components/Page.tsx 📉 -1 B (-0.05%) 1.96 kB → 1.96 kB
src/components/sidebar/Account.tsx 📉 -4 B (-0.08%) 4.76 kB → 4.76 kB
src/style/themes/dark.ts 📉 -241 B (-2.39%) 9.83 kB → 9.6 kB
src/style/themes/light.ts 📉 -242 B (-2.41%) 9.81 kB → 9.57 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

Asset File Size % Changed
static/js/main.js 1.15 MB → 1.15 MB (-408 B) -0.03%

Unchanged

Asset File Size % Changed
static/js/460.chunk.js 774.35 kB 0%
static/media/Inter-italic.var.woff2 239.29 kB 0%
static/media/Inter-roman.var.woff2 221.86 kB 0%
static/js/444.chunk.js 156.11 kB 0%
static/js/wide-components.chunk.js 127.16 kB 0%
static/js/231.chunk.js 117.37 kB 0%
static/js/narrow-components.chunk.js 52.15 kB 0%
static/js/reports.chunk.js 35.97 kB 0%
static/js/473.chunk.js 13 kB 0%
static/js/312.chunk.js 12.92 kB 0%
static/js/resize-observer-polyfill.chunk.js 8.88 kB 0%
static/css/main.css 7.41 kB 0%
asset-manifest.json 2.07 kB 0%
index.html 1.66 kB 0%
static/media/browser-server.js 903 B 0%

Copy link
Contributor

github-actions bot commented Nov 9, 2023

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
2 2.22 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.23 MB 0%
xfo.xfo.kcab.worker.js 1014.46 kB 0%

@rich-howell
Copy link
Contributor

@rich-howell , can you do your AA and AAA checks on these?

For the selected item it now passes :)

image

@rich-howell
Copy link
Contributor

This PR for whatever reason also seems to resolve #1869

image

@youngcw
Copy link
Member

youngcw commented Nov 13, 2023

I feel like the new sidebar colors don't match the other colors. The new sidebar looks way more gray than the other blue hue colors.

@carkom
Copy link
Contributor Author

carkom commented Nov 13, 2023

I feel like the new sidebar colors don't match the other colors. The new sidebar looks way more gray than the other blue hue colors.

The reason for the move to gray is to create contrast between the tables and the sidebar.

"navy700" blends in with split transactions
"navy800" blends with table background

I'm open to suggestions.

image
image

@carkom
Copy link
Contributor Author

carkom commented Nov 13, 2023

Navy900 give good contrast and keeps with the theme. I like that, what do you think?

image

@youngcw
Copy link
Member

youngcw commented Nov 13, 2023

I like that navy900 option. Is that the same as the light theme?

@carkom
Copy link
Contributor Author

carkom commented Nov 13, 2023

I like that navy900 option. Is that the same as the light theme?

It is.

@carkom
Copy link
Contributor Author

carkom commented Nov 13, 2023

I agree, I like it better as well. Adds some synergy being the same in both themes.

@carkom carkom merged commit 7fdd976 into actualbudget:master Nov 16, 2023
19 checks passed
@trafico-bot trafico-bot bot added the ✨ Merged Pull Request has been merged successfully label Nov 16, 2023
@carkom carkom deleted the sidebarDark branch November 16, 2023 08:06
carkom added a commit that referenced this pull request Nov 16, 2023
FlorianLang06 pushed a commit to FlorianLang06/actual that referenced this pull request Mar 7, 2024
* sideBar Dark Color changes

* notes

* VRT updates

* test fixes

* color fixes

* Revert "test fixes"

This reverts commit 3c6131b.

* Revert "VRT updates"

This reverts commit b84d765.

* color update

* VRT updates

* calendar changes

* VRT update

* notes update

* color change

* Revert "VRT update"

This reverts commit 4c5aba4.

* Revert "VRT updates"

This reverts commit ba142b0.

* VRT updates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants