Fix crash when undoing a rule application #1885
Conversation
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jfdoming
force-pushed
the
jfdoming/rules-modal-undo-crash-fix
branch
from
d70c655 to
ca3a778
Compare
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
|
@jfdoming Thank you for creating a fix! I can verify that this fixes the issue but I can't seem to replicate the behavior mentioned in your question. Could you create an issue for it and provide some steps to reproduce? We can merge this PR and handle the other issue on a separate one. |
| @@ -137,7 +137,7 @@ export default function Modals() { | |||
| return ( | |||
| <ManageRulesModal | |||
| modalProps={modalProps} | |||
| payeeId={options.payeeId} | |||
| payeeId={options?.payeeId} | |||
There was a problem hiding this comment.
❓ question: is this change necessary? Doesn't the change in ManageRules.tsx already solve the problem?
There was a problem hiding this comment.
It's not strictly necessary, but modals.d.ts in loot-core lists payeeId as optional, so I thought it would make sense to match here!
There was a problem hiding this comment.
That makes sense. Thanks for explaining!
Sounds good! I added one here: #1945 |
trafico-bot
bot
added
✨ Merged
* Undo shouldn't open modal if it wasn't open before * Add release notes
Fix crash when hitting undo after applying a rule to some transactions (closes #1831).
Question: This fix exposes some weird (pre-existing) behaviour, where hitting undo for a rule-apply causes the application to send you to the rules page with no modal open, which is confusing as you do not see the transactions you are undoing the change for. We could:
IMHO 1 makes more sense and would be easier to implement, but I'm curious which you think is better! A similar issue also exists on the Payees page.