Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance: BudgetSummaries, MonthPicker, SidebarCategory components to tsx. #1879

Merged

Conversation

MikesGlitch
Copy link
Contributor

@MikesGlitch MikesGlitch commented Nov 8, 2023

Convert BudgetSummaries, MonthPicker, SidebarCategory components to Typescript.

#1483

Copy link

netlify bot commented Nov 8, 2023

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 26ee152
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/654e9ee68f5a850008585cb7
😎 Deploy Preview https://deploy-preview-1879.demo.actualbudget.org/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@MikesGlitch MikesGlitch changed the title moving some files to tsx Maintenance: BudgetSummaryies to tsx Nov 8, 2023
@MikesGlitch MikesGlitch changed the title Maintenance: BudgetSummaryies to tsx Maintenance: BudgetSummaries to tsx Nov 8, 2023
Copy link
Contributor

github-actions bot commented Nov 8, 2023

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
16 2.83 MB → 2.83 MB (-49 B) -0.00%
Changeset
File Δ Size
src/components/budget/SidebarCategory.tsx 🆕 +6.37 kB 0 B → 6.37 kB
src/components/budget/MonthPicker.tsx 🆕 +5.24 kB 0 B → 5.24 kB
src/components/budget/BudgetSummaries.tsx 🆕 +2.98 kB 0 B → 2.98 kB
src/components/budget/ExpenseGroup.js 📉 -9 B (-0.26%) 3.41 kB → 3.4 kB
src/components/budget/SidebarCategory.js 🔥 -6.42 kB (-100%) 6.42 kB → 0 B
src/components/budget/MonthPicker.js 🔥 -5.24 kB (-100%) 5.24 kB → 0 B
src/components/budget/BudgetSummaries.js 🔥 -2.99 kB (-100%) 2.99 kB → 0 B
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

Asset File Size % Changed
static/js/wide-components.chunk.js 127.17 kB → 127.12 kB (-48 B) -0.04%
static/js/main.js 1.12 MB → 1.12 MB (-1 B) -0.00%

Unchanged

Asset File Size % Changed
static/js/848.chunk.js 760.98 kB 0%
static/media/Inter-italic.var.woff2 239.29 kB 0%
static/media/Inter-roman.var.woff2 221.86 kB 0%
static/js/444.chunk.js 156.11 kB 0%
static/js/231.chunk.js 117.37 kB 0%
static/js/narrow-components.chunk.js 52.15 kB 0%
static/js/reports.chunk.js 30 kB 0%
static/js/473.chunk.js 13 kB 0%
static/js/312.chunk.js 12.77 kB 0%
static/js/resize-observer-polyfill.chunk.js 8.88 kB 0%
static/css/main.css 7.41 kB 0%
asset-manifest.json 2.07 kB 0%
index.html 1.66 kB 0%
static/media/browser-server.js 903 B 0%

Copy link
Contributor

github-actions bot commented Nov 8, 2023

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
2 2.22 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.23 MB 0%
xfo.xfo.kcab.worker.js 1014.46 kB 0%

@@ -13,7 +13,6 @@ function ExpenseGroup({
collapsed,
editingCell,
dragState,
itemPos,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused and never specified

function SidebarCategory({
innerRef,
category,
dragPreview,
dragging,
editing,
style,
borderColor = theme.tableBorder,
Copy link
Contributor Author

@MikesGlitch MikesGlitch Nov 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

never used, never specified for all the deleted

@MikesGlitch MikesGlitch changed the title Maintenance: BudgetSummaries to tsx Maintenance: Convert BudgetSummaries, MonthPicker, SidebarCategory components to Typescript. Nov 8, 2023
@MikesGlitch MikesGlitch changed the title Maintenance: Convert BudgetSummaries, MonthPicker, SidebarCategory components to Typescript. Maintenance: BudgetSummaries, MonthPicker, SidebarCategory components to tsx. Nov 8, 2023
@MikesGlitch MikesGlitch marked this pull request as ready for review November 8, 2023 22:42
@MikesGlitch MikesGlitch force-pushed the maintenance/ts-refactor-components branch from e3d4739 to 0a64033 Compare November 9, 2023 20:33
@MikesGlitch MikesGlitch force-pushed the maintenance/ts-refactor-components branch from e518d17 to 26ee152 Compare November 10, 2023 21:21
@MatissJanis MatissJanis merged commit 7062f2a into actualbudget:master Nov 10, 2023
16 of 19 checks passed
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved labels Nov 10, 2023
@MikesGlitch MikesGlitch deleted the maintenance/ts-refactor-components branch November 10, 2023 21:52
FlorianLang06 pushed a commit to FlorianLang06/actual that referenced this pull request Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants