✅ (VRT) darkmode visual regression tests

[MatissJanis]

Adding darkmode VRT tests to catch regressions in darkmode too.

[netlify]

✅ Deploy Preview for actualbudget ready!

Name	Link
🔨 Latest commit	0938e82
🔍 Latest deploy log	https://app.netlify.com/sites/actualbudget/deploys/654e9ccd22be1c0008d3ebbd
😎 Deploy Preview	https://deploy-preview-1860.demo.actualbudget.org
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[github-actions]

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
16	2.83 MB → 2.83 MB (+70 B)	+0.00%

Changeset

File	Δ	Size
src/global-events.js	📈 +111 B (+2.15%)	5.05 kB → 5.15 kB
src/browser-preload.browser.js	📈 +22 B (+0.48%)	4.5 kB → 4.52 kB

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset	File Size	% Changed
static/js/main.js	1.12 MB → 1.12 MB (+70 B)	+0.01%

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
static/js/848.chunk.js	760.98 kB	0%
static/media/Inter-italic.var.woff2	239.29 kB	0%
static/media/Inter-roman.var.woff2	221.86 kB	0%
static/js/444.chunk.js	156.11 kB	0%
static/js/wide-components.chunk.js	127.17 kB	0%
static/js/231.chunk.js	117.37 kB	0%
static/js/narrow-components.chunk.js	52.15 kB	0%
static/js/reports.chunk.js	30 kB	0%
static/js/473.chunk.js	13 kB	0%
static/js/312.chunk.js	12.77 kB	0%
static/js/resize-observer-polyfill.chunk.js	8.88 kB	0%
static/css/main.css	7.41 kB	0%
asset-manifest.json	2.07 kB	0%
index.html	1.66 kB	0%
static/media/browser-server.js	903 B	0%

[github-actions]

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
2	2.22 MB	0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
kcab.worker.js	1.23 MB	0%
xfo.xfo.kcab.worker.js	1014.46 kB	0%

[joel-jeremy]

I noticed some of the changed screenshots are no longer doing the same thing. Is this expected?

[MatissJanis]

@joel-jeremy it's a bit confusing, but there actually aren't any changes. Github UI is just showing the wrong diff.

The screenshot names are sequentialy indexed. So..

Before:

some-test-name-1.png // first assertion
some-test-name-2.png // second assertion

After:

some-test-name-1.png // first assertion w/ lightmode
some-test-name-2.png // first assertion w/ darkmode
some-test-name-3.png // second assertion w/ lightmode
some-test-name-4.png // second assertion w/ darkmode

[joel-jeremy]

Looks good! Thanks for the clarification :)