Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mobile create account #1853

Merged
merged 7 commits into from
Nov 19, 2023
Merged

Mobile create account #1853

merged 7 commits into from
Nov 19, 2023

Conversation

joel-jeremy
Copy link
Contributor

No description provided.

@netlify Netlify
Copy link

netlify bot commented Nov 3, 2023 •
edited
Loading

✅ Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 0777423
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/655658b73de16d00089ccb2f
😎 Deploy Preview https://deploy-preview-1853.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 3, 2023 •
edited
Loading

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
16 2.97 MB → 2.97 MB (+453 B) +0.01%
Changeset
File Δ Size
src/components/Page.tsx 📈 +1.16 kB (+59.26%) 1.96 kB → 3.12 kB
src/components/accounts/MobileAccounts.js 📈 +146 B (+1.50%) 9.49 kB → 9.64 kB
src/components/modals/CreateLocalAccount.tsx 📈 +54 B (+0.61%) 8.66 kB → 8.71 kB
src/components/transactions/MobileTransaction.js 📈 +70 B (+0.14%) 50.48 kB → 50.55 kB
src/components/accounts/MobileAccountDetails.js 📉 -1.56 kB (-14.45%) 10.81 kB → 9.25 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
static/js/main.js 1.15 MB → 1.15 MB (+450 B) +0.04%
static/js/narrow-components.chunk.js 53.17 kB → 53.18 kB (+3 B) +0.01%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/665.chunk.js 824.28 kB 0%
static/media/Inter-italic.var.woff2 239.29 kB 0%
static/media/Inter-roman.var.woff2 221.86 kB 0%
static/js/444.chunk.js 156.11 kB 0%
static/js/wide-components.chunk.js 127.18 kB 0%
static/js/231.chunk.js 117.37 kB 0%
static/js/reports.chunk.js 74.37 kB 0%
static/js/301.chunk.js 13.31 kB 0%
static/js/473.chunk.js 13 kB 0%
static/js/resize-observer-polyfill.chunk.js 8.88 kB 0%
static/css/main.css 7.41 kB 0%
asset-manifest.json 2.07 kB 0%
index.html 1.66 kB 0%
static/media/browser-server.js 903 B 0%

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 3, 2023 •
edited
Loading

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
2 2.22 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.23 MB 0%
xfo.xfo.kcab.worker.js 1014.46 kB 0%

@joel-jeremy joel-jeremy force-pushed the mobile-create-account branch from 1f81e24 to 798a565 Compare November 3, 2023 20:17
@youngcw
Copy link
Member

youngcw commented Nov 9, 2023

Functionally this seems to be working great. I cant help with testing goCardless sadly.

@carkom
Copy link
Contributor

carkom commented Nov 10, 2023

So local account creation works fine. Found a couple bugs in the GoCardless and server sync process.

  • When setting up a new server you get an error about mobile account creation when adding your first account. Then you get stuck on this page since you can't go back and use "don't use server" button anymore. The server/add file workflow is not at all accessible from mobile from what I can tell.
    image

  • If using existing server and adding a Go Cardless account (not the first account) using the new "+" button. All works fine until the end of the flow. In desktop a new window is open to step through GoCardless process. Upon completion you get redirected to actual app but no new account is added. You have to close this new window to see the "add new account" process you were going through in the original window this is the same in desktop app (not a great experience, but also not part of this PR). The button on this window gets cut off in the table of this flow. This whole table needs adjusting in mobile.
    image

  • When you click to "create new account" in the drop down of the above SS the account gets added successfully. I didn't have any errors in this process so I'm not sure how those might look.

@joel-jeremy joel-jeremy force-pushed the mobile-create-account branch from 798a565 to 4a1ca30 Compare November 10, 2023 15:33
@joel-jeremy
Copy link
Contributor Author

joel-jeremy commented Nov 10, 2023 •
edited
Loading

@carkom Thank you for testing out the go cardless functionality! I have addressed the first bullet - adding accounts should now work when there are no existing accounts yet. I think we should address the other bullet in a different PR. If you have time, could you create an issue for it?

@shall0pass
Copy link
Contributor

In the mobile transaction entry page, we bring up a numeric keyboard for entries. Could we bring up the same numeric keyboard for the initial account balance box here when on mobile?

@carkom
Copy link
Contributor

carkom commented Nov 10, 2023

@carkom Thank you for testing out the go cardless functionality! I have addressed the first bullet - adding accounts should now work when there are no existing accounts yet. I think we should address the other bullet in a different PR. If you have time, could you create an issue for it?

#1894

@joel-jeremy
Copy link
Contributor Author

Thank you! Is the current implementation usable / good to go or do you think there are issues that needs to be fixed first before this gets merged?

@joel-jeremy joel-jeremy force-pushed the mobile-create-account branch 5 times, most recently from 44443fc to 39997d7 Compare November 15, 2023 23:16
@joel-jeremy joel-jeremy force-pushed the mobile-create-account branch from 39997d7 to bce471f Compare November 16, 2023 16:44
@joel-jeremy joel-jeremy merged commit b553008 into actualbudget:master Nov 19, 2023
19 checks passed
@trafico-bot trafico-bot bot added the ✨ Merged Pull Request has been merged successfully label Nov 19, 2023
FlorianLang06 pushed a commit to FlorianLang06/actual that referenced this pull request Mar 7, 2024
@joel-jeremy
Mobile create account (actualbudget#1853)
4c844fa 
* Mobile create account

* Release notes

* Update add button style

* Add back desktop page header padding

* Empty accounts handling

* decimal keyboard on CreateLocalAccount balance input

* VRT updates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youngcw youngcw youngcw approved these changes

Assignees
No one assigned
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joel-jeremy @youngcw @carkom @shall0pass