Center name in mobile account page

[joel-jeremy]

No description provided.

[netlify]

✅ Deploy Preview for actualbudget ready!

Name	Link
🔨 Latest commit	82b7bd4
🔍 Latest deploy log	https://app.netlify.com/sites/actualbudget/deploys/65565c868b2d49000983a4c5
😎 Deploy Preview	https://deploy-preview-1851.demo.actualbudget.org/
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[github-actions]

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
16	2.97 MB → 2.97 MB (+19 B)	+0.00%

Changeset

File	Δ	Size
src/components/accounts/MobileAccountDetails.js	📈 +57 B (+0.51%)	10.81 kB → 10.87 kB

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset	File Size	% Changed
static/js/narrow-components.chunk.js	53.17 kB → 53.19 kB (+19 B)	+0.03%

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
static/js/main.js	1.15 MB	0%
static/js/665.chunk.js	824.28 kB	0%
static/media/Inter-italic.var.woff2	239.29 kB	0%
static/media/Inter-roman.var.woff2	221.86 kB	0%
static/js/444.chunk.js	156.11 kB	0%
static/js/wide-components.chunk.js	127.18 kB	0%
static/js/231.chunk.js	117.37 kB	0%
static/js/reports.chunk.js	74.37 kB	0%
static/js/301.chunk.js	13.31 kB	0%
static/js/473.chunk.js	13 kB	0%
static/js/resize-observer-polyfill.chunk.js	8.88 kB	0%
static/css/main.css	7.41 kB	0%
asset-manifest.json	2.07 kB	0%
index.html	1.66 kB	0%
static/media/browser-server.js	903 B	0%

[github-actions]

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
2	2.22 MB	0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
kcab.worker.js	1.23 MB	0%
xfo.xfo.kcab.worker.js	1014.46 kB	0%

[MatissJanis]

Would you mind posting a before & after screenshot? I'm not sure where to look.

[joel-jeremy]

I'm on mobile right now, but you can try creating an account with a long name and open the account details. Without this change, the long account name will be left aligned.

[MatissJanis]

Ok, I see now. Hmm.. I wonder if it would be better to truncate it with an ellipsis instead.

[joel-jeremy]

That's also possible. Maybe truncate after 2 lines, just like the category names in the mobile budget page?

[MatissJanis]

That's also possible. Maybe truncate after 2 lines, just like the category names in the mobile budget page?

I'm not a big fan of how we handle category names currently in the budget page.

For example:

Personally I think just allowing a single line and truncating with an ellipsis makes for the most aesthetically pleasing interface, but I don't want to impose my view on this too much. Happy to go with the 2-line approach too :)

[joel-jeremy]

I'm also good with truncating a single line but we need to add a way for users to view the entire account name. Any ideas?

[MatissJanis]

I'm also good with truncating a single line but we need to add a way for users to view the entire account name. Any ideas?

Maybe opening a tooltip or modal on long click? Though maybe that's an overkill..

https://minwork.gitbook.io/long-press-hook/

[joel-jeremy]

A modal could work. We could also extend it to show/edit the notes, rename/close/export account, and reconcile (but maybe we should create another modal for reconcile which opens when the amount is clicked on the mobile account page and this other modal also shows the cleared/uncleared totals).

And the same thing could also be applied to the budget category name. It could open a modal on click which shows/edits the category name and the category notes, but that could be done on another PR.

[carkom]

All good!

[github-actions]

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

[github-actions]

This PR was closed because it has been stalled for 5 days with no activity.