Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed:issue->#1762 Schedule creation modal notify user of weekend skip option #1840

Merged
merged 4 commits into from
Nov 4, 2023
Merged

Conversation

sethgillett
Copy link
Contributor

@sethgillett sethgillett commented Oct 29, 2023

Add a suffix to recurring transaction date description to indicate whether it posts before / after weekend. Adds (before weekend or (after weekend) to the date description if the move weekend option is selected.

This addresses #1762

@netlify
Copy link

netlify bot commented Oct 29, 2023

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 1437d18
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/653ecadaa18a78000801af99
😎 Deploy Preview https://deploy-preview-1840.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sethgillett sethgillett marked this pull request as draft October 29, 2023 20:51
@github-actions
Copy link
Contributor

github-actions bot commented Oct 29, 2023

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
16 2.82 MB → 2.82 MB (+67 B) +0.00%
Changeset
File Δ Size
../loot-core/src/shared/schedules.ts 📈 +181 B (+2.24%) 7.91 kB → 8.08 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
static/js/main.js 1.12 MB → 1.12 MB (+67 B) +0.01%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/848.chunk.js 760.98 kB 0%
static/media/Inter-italic.var.woff2 239.29 kB 0%
static/media/Inter-roman.var.woff2 221.86 kB 0%
static/js/444.chunk.js 156.11 kB 0%
static/js/wide-components.chunk.js 125.89 kB 0%
static/js/231.chunk.js 117.37 kB 0%
static/js/narrow-components.chunk.js 45.69 kB 0%
static/js/reports.chunk.js 29.97 kB 0%
static/js/473.chunk.js 13 kB 0%
static/js/312.chunk.js 12.78 kB 0%
static/js/resize-observer-polyfill.chunk.js 8.88 kB 0%
static/css/main.css 7.41 kB 0%
asset-manifest.json 2.07 kB 0%
index.html 1.66 kB 0%
static/media/browser-server.js 903 B 0%

@github-actions
Copy link
Contributor

github-actions bot commented Oct 29, 2023

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
2 2.22 MB → 2.22 MB (+72 B) +0.00%
Changeset
File Δ Size
packages/loot-core/src/shared/schedules.ts 📈 +181 B (+2.24%) 7.91 kB → 8.08 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
kcab.worker.js 1.23 MB → 1.23 MB (+72 B) +0.01%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
xfo.xfo.kcab.worker.js 1014.46 kB 0%

@sethgillett sethgillett marked this pull request as ready for review October 29, 2023 21:15
@rich-howell
Copy link
Contributor

Add a suffix to recurring transaction date description to indicate whether it posts before / after weekend. Adds (before weekend or (after weekend) to the date description if the move weekend option is selected.

This addresses #1762

This does the trick quite nicely.

Copy link
Member

@MatissJanis MatissJanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@MatissJanis MatissJanis merged commit a549cdf into actualbudget:master Nov 4, 2023
17 checks passed
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved labels Nov 4, 2023
FlorianLang06 pushed a commit to FlorianLang06/actual that referenced this pull request Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants